docs: added gRPC custom name resolver proposal #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pradeepbbl
force-pushed
the
pmishra/rfc-grpc-name-resolver
branch
2 times, most recently
from
323f0b6
to
cd2cacc
Compare
added 2 commits
September 25, 2024 00:29
Added initial gRPC custom name resolver draft proposal Signed-off-by: Pradeep Mishra <pradeep.mishra@booking.com> Signed-off-by: Pradeep <pradeepbbl@gmail.com>
Signed-off-by: Pradeep Mishra <pradeep.mishra@booking.com> Signed-off-by: Pradeep <pradeepbbl@gmail.com>
pradeepbbl
force-pushed
the
pmishra/rfc-grpc-name-resolver
branch
from
cd2cacc
to
e8fe78d
Compare
toddbaert
reviewed
Sep 25, 2024
docs/reference/specifications/proposal/rfc-grpc-custom-name-resolver.md
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Sep 25, 2024
docs/reference/specifications/proposal/rfc-grpc-custom-name-resolver.md
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Sep 25, 2024
docs/reference/specifications/proposal/rfc-grpc-custom-name-resolver.md
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Sep 25, 2024
docs/reference/specifications/proposal/rfc-grpc-custom-name-resolver.md
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Sep 25, 2024
docs/reference/specifications/proposal/rfc-grpc-custom-name-resolver.md
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Sep 25, 2024
docs/reference/specifications/proposal/rfc-grpc-custom-name-resolver.md
Outdated
Show resolved
Hide resolved
|
I have a few nits but fundamentally agree. Once we merge this I will create some issues. |
…solver.md Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Pradeep Mishra <pradeepbbl@users.noreply.github.com>
…solver.md Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Pradeep Mishra <pradeepbbl@users.noreply.github.com>
…solver.md Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Pradeep Mishra <pradeepbbl@users.noreply.github.com>
…solver.md Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Pradeep Mishra <pradeepbbl@users.noreply.github.com> Signed-off-by: Pradeep <pradeepbbl@gmail.com>
pradeepbbl
force-pushed
the
pmishra/rfc-grpc-name-resolver
branch
from
7769761
to
ae48f03
Compare
Signed-off-by: Pradeep Mishra <pradeepbbl@gmail.com> Signed-off-by: Pradeep <pradeepbbl@gmail.com>
pradeepbbl
force-pushed
the
pmishra/rfc-grpc-name-resolver
branch
from
ae48f03
to
7f47d45
Compare
beeme1mr
reviewed
Sep 25, 2024
docs/reference/specifications/proposal/rfc-grpc-custom-name-resolver.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Pradeep Mishra <pradeepbbl@users.noreply.github.com>
beeme1mr
approved these changes
Sep 26, 2024
toddbaert
approved these changes
Oct 1, 2024
|
I will create some issues out of this. |
|
@pradeepbbl I've created open-feature/java-sdk-contrib#995 and open-feature/go-sdk-contrib#585. Please confirm they make sense to you, and feel free to comment on them if you'd like to work in them. |
toddbaert
added a commit
to open-feature/community
that referenced
this pull request
Oct 1, 2024
@pradeepbbl has been working on some enhancements to flagd providers to support custom name resolvers: open-feature/flagd#1414 @pradeepbbl when this is merged, it will add you to the org. Being in the org comes with no obligation but allows us to assign you and ping you easier, etc. Please 👍 or approve this PR if you want to join and you will get an email invite. Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Added initial gRPC custom name resolver draft proposal
Related Issues
TBD