-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support blob type sources and GCS as an example of such source. #1366
Conversation
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Alan Kutniewski <kutniewski@google.com>
Signed-off-by: Alan Kutniewski <kutniewski@google.com>
Hey @alan-kut, thanks for the PR. I'll test this out E2E tomorrow. |
Thanks. I fixed lint error and data race. Few assumptions I made in this code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this locally and it works great. My only concern is the size of the change detection log message.
Could you please sign off your comments and update the sync config docs when you get a moment?
…eature#1367) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [connectrpc.com/otelconnect](https://togithub.com/connectrpc/otelconnect-go) | `v0.7.0` -> `v0.7.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/connectrpc.com%2fotelconnect/v0.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/connectrpc.com%2fotelconnect/v0.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/connectrpc.com%2fotelconnect/v0.7.0/v0.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/connectrpc.com%2fotelconnect/v0.7.0/v0.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>connectrpc/otelconnect-go (connectrpc.com/otelconnect)</summary> ### [`v0.7.1`](https://togithub.com/connectrpc/otelconnect-go/releases/tag/v0.7.1) [Compare Source](https://togithub.com/connectrpc/otelconnect-go/compare/v0.7.0...v0.7.1) This is a bug-fix release that addresses a race condition when closing a stream. #### What's Changed ##### Bugfixes - Fix data race in streaming client close by [@​emcfarlane](https://togithub.com/emcfarlane) in [#​173](https://togithub.com/connectrpc/otelconnect-go/issues/173) #### New Contributors - [@​gvacaliuc](https://togithub.com/gvacaliuc) made their first contribution in [#​163](https://togithub.com/connectrpc/otelconnect-go/issues/163) - [@​ytnsym](https://togithub.com/ytnsym) made their first contribution in [#​176](https://togithub.com/connectrpc/otelconnect-go/issues/176) - [@​drice-buf](https://togithub.com/drice-buf) made their first contribution in [#​178](https://togithub.com/connectrpc/otelconnect-go/issues/178) **Full Changelog**: connectrpc/otelconnect-go@v0.7.0...v0.7.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Alan Kutniewski <kutniewski@google.com>
Signed-off-by: Alan Kutniewski <kutniewski@google.com>
I changed the log to debug, signed off commit, updated the docs (in a new commit). Should I squash the commits somehow? |
boject in the init. Signed-off-by: Alan Kutniewski <kutniewski@google.com>
I've reviewed all the licensing issues detected by FOSSA. The library is licensed BSD-3, but comments in the code referred to other licenses, which triggered a false positive. |
Signed-off-by: Alan Kutniewski <kutniewski@google.com>
Commits are squashed automatically, everything will be clean in main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool addition.
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.11.2</summary> ## [0.11.2](flagd/v0.11.1...flagd/v0.11.2) (2024-08-22) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to v1.5.1-20240215170432-1e611e2999cc.1 ([#1372](#1372)) ([ae24595](ae24595)) * **deps:** update module github.com/open-feature/flagd/core to v0.10.1 ([#1355](#1355)) ([8fcfb14](8fcfb14)) * **deps:** update module golang.org/x/net to v0.28.0 ([#1380](#1380)) ([239a432](239a432)) * **deps:** update module golang.org/x/sync to v0.8.0 ([#1378](#1378)) ([4804c17](4804c17)) ### 🧹 Chore * **deps:** update dependency go to v1.22.6 ([#1297](#1297)) ([50b92c1](50b92c1)) * **deps:** update golang docker tag to v1.23 ([#1382](#1382)) ([abb5ca3](abb5ca3)) * improve gRPC sync service shutdown behavior ([#1375](#1375)) ([79d9085](79d9085)) </details> <details><summary>flagd-proxy: 0.6.5</summary> ## [0.6.5](flagd-proxy/v0.6.4...flagd-proxy/v0.6.5) (2024-08-22) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to v1.5.1-20240215170432-1e611e2999cc.1 ([#1372](#1372)) ([ae24595](ae24595)) * **deps:** update module github.com/open-feature/flagd/core to v0.10.1 ([#1355](#1355)) ([8fcfb14](8fcfb14)) * **deps:** update module golang.org/x/net to v0.28.0 ([#1380](#1380)) ([239a432](239a432)) * **deps:** update module golang.org/x/sync to v0.8.0 ([#1378](#1378)) ([4804c17](4804c17)) ### 🧹 Chore * **deps:** update dependency go to v1.22.6 ([#1297](#1297)) ([50b92c1](50b92c1)) * **deps:** update golang docker tag to v1.23 ([#1382](#1382)) ([abb5ca3](abb5ca3)) ### 📚 Documentation * **flagd-proxy:** removed invalid grpc prefix from uri config ([4911697](4911697)) </details> <details><summary>core: 0.10.2</summary> ## [0.10.2](core/v0.10.1...core/v0.10.2) (2024-08-22) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to v1.5.1-20240215170432-1e611e2999cc.1 ([#1372](#1372)) ([ae24595](ae24595)) * **deps:** update module connectrpc.com/otelconnect to v0.7.1 ([#1367](#1367)) ([184915b](184915b)) * **deps:** update module github.com/open-feature/open-feature-operator/apis to v0.2.44 ([#1368](#1368)) ([0c68726](0c68726)) * **deps:** update module golang.org/x/crypto to v0.26.0 ([#1379](#1379)) ([05f6658](05f6658)) * **deps:** update module golang.org/x/mod to v0.20.0 ([#1377](#1377)) ([797d7a4](797d7a4)) * **deps:** update module golang.org/x/sync to v0.8.0 ([#1378](#1378)) ([4804c17](4804c17)) ### ✨ New Features * add 'watcher' interface to file sync ([#1365](#1365)) ([61fff43](61fff43)) * added new grpc sync config option to allow setting max receive message size. ([#1358](#1358)) ([bed077b](bed077b)) * Support blob type sources and GCS as an example of such source. ([#1366](#1366)) ([21f2c9a](21f2c9a)) ### 🧹 Chore * **deps:** update dependency go to v1.22.6 ([#1297](#1297)) ([50b92c1](50b92c1)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
Notes
In a similar fashion other cloud storages supported by go-cloud blob can be added.
How to test