-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serve sync.proto on port 8015 #1237
feat: serve sync.proto on port 8015 #1237
Conversation
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
+ Coverage 73.69% 77.11% +3.42%
==========================================
Files 32 19 -13
Lines 3140 1547 -1593
==========================================
- Hits 2314 1193 -1121
+ Misses 717 273 -444
+ Partials 109 81 -28 ☔ View full report in Codecov by Sentry. |
8b0323e
to
a909e87
Compare
7572ba3
to
d042c9a
Compare
When starting flagd like this:
Then attempting to resolve JUST that selector like this:
I get:
Is there some normalization happening? I would have thought I could select based on this. Note that omitting the EDIT:
This seems a bit brittle and confusing, but I think it's out of scope of this PR. I think we should just document it for now, and perhaps add a new PR that allows users to define an friendly label for each source in the JSON config mode. |
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
1c330ff
to
5eac82f
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Merging with all the approvals. Thank you @thisthat @toddbaert @bacherfl @beeme1mr for reviews 🤝 |
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.9.1</summary> ## [0.9.1](flagd/v0.9.0...flagd/v0.9.1) (2024-03-15) ### 🐛 Bug Fixes * **deps:** update module google.golang.org/protobuf to v1.33.0 [security] ([#1248](#1248)) ([b2b0fa1](b2b0fa1)) * update protobuff CVE-2024-24786 ([#1249](#1249)) ([fd81c23](fd81c23)) ### ✨ New Features * serve sync.proto on port 8015 ([#1237](#1237)) ([7afdc0c](7afdc0c)) ### 🧹 Chore * move packaging & isolate service implementations ([#1234](#1234)) ([b58fab3](b58fab3)) </details> <details><summary>flagd-proxy: 0.5.1</summary> ## [0.5.1](flagd-proxy/v0.5.0...flagd-proxy/v0.5.1) (2024-03-15) ### 🐛 Bug Fixes * update protobuff CVE-2024-24786 ([#1249](#1249)) ([fd81c23](fd81c23)) ### 🧹 Chore * move packaging & isolate service implementations ([#1234](#1234)) ([b58fab3](b58fab3)) </details> <details><summary>core: 0.8.1</summary> ## [0.8.1](core/v0.8.0...core/v0.8.1) (2024-03-15) ### 🐛 Bug Fixes * occasional panic when watched YAML files change ([#1246](#1246)) ([6249d12](6249d12)) * update protobuff CVE-2024-24786 ([#1249](#1249)) ([fd81c23](fd81c23)) ### 🧹 Chore * move packaging & isolate service implementations ([#1234](#1234)) ([b58fab3](b58fab3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
Introduce flag sync capability to flagd as discussed at [1] and fixes #1230 .
What's changed ?
The change included with this PR introduces the gRPC sync contract [2]. This allows flagd to expose its store to in-process provider which consumes gRPC flag stream.
How to use ?
flagd will start sync service on port
8015
. You can alter the default sync port by providing desired port to the startup flagsyncPort
(--sync-port=8686
)Implementation details
selector
can be used to specify the specific flag source. If unset, all flags will be sent[1] - #1153
[2] - https://github.com/open-feature/flagd-schemas/blob/main/protobuf/flagd/sync/v1/sync.proto