fix: add custom marshalling options #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
=======================================
Coverage 73.43% 73.43%
=======================================
Files 32 32
Lines 3113 3113
=======================================
Hits 2286 2286
Misses 719 719
Partials 108 108 ☔ View full report in Codecov by Sentry. |
Kavindu-Dodan
approved these changes
Jan 3, 2024
toddbaert
approved these changes
Jan 3, 2024
bacherfl
approved these changes
Jan 4, 2024
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Kavindu-Dodan
force-pushed
the
1116-bug-there-is-no-value-key-in-the-evaluation-response
branch
from
1792d80 to
41c5764
Compare
Merged
beeme1mr
pushed a commit
that referenced
this pull request
Jan 4, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.8.1</summary> ## [0.8.1](flagd/v0.8.0...flagd/v0.8.1) (2024-01-04) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.7.3 ([#1104](#1104)) ([b6c00c7](b6c00c7)) * **deps:** update module github.com/spf13/viper to v1.18.2 ([#1069](#1069)) ([f0d6206](f0d6206)) </details> <details><summary>flagd-proxy: 0.4.1</summary> ## [0.4.1](flagd-proxy/v0.4.0...flagd-proxy/v0.4.1) (2024-01-04) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.7.3 ([#1104](#1104)) ([b6c00c7](b6c00c7)) * **deps:** update module github.com/spf13/viper to v1.18.2 ([#1069](#1069)) ([f0d6206](f0d6206)) </details> <details><summary>core: 0.7.4</summary> ## [0.7.4](core/v0.7.3...core/v0.7.4) (2024-01-04) ### 🐛 Bug Fixes * add custom marshalling options ([#1117](#1117)) ([e8e49de](e8e49de)) * **deps:** update kubernetes packages to v0.29.0 ([#1082](#1082)) ([751a79a](751a79a)) * **deps:** update module connectrpc.com/connect to v1.14.0 ([#1108](#1108)) ([0a41aca](0a41aca)) * **deps:** update module github.com/prometheus/client_golang to v1.18.0 ([#1110](#1110)) ([745bbb0](745bbb0)) * **deps:** update module golang.org/x/crypto to v0.17.0 [security] ([#1090](#1090)) ([26681de](26681de)) * **deps:** update module google.golang.org/protobuf to v1.32.0 ([#1106](#1106)) ([e0d3b34](e0d3b34)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1116
Notes
I manually tested to confirm the fix is working. However, it's currently not automatically tested because the issue only affects HTTP-based requests, and the E2E tests use gRPC. I'll create a follow-up task to expand the E2E test suite to include HTTP tests.