Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new grpc sync config option to allow setting max receive message size. #1358

Merged

Conversation

pradeepbbl
Copy link
Member

This PR

Added a new config option maxMsgSize which will
allow users to override default message size 4Mb.

  • allow override default max message size 4Mb

Related Issues

Fixes #1357

How to test

To test this feature you need a flag source with large number of flags > 4Mb, e.g. below we are running with max size of 5Mb+

./flagd start --port 8013 --sync-port 8017 --sources='[{"uri": "localhost:8015", "provider": "grpc", "tls": false, "providerID": "flagd-sidecar", "selector": "all-flags", "maxMsgSize": 5728474}]'

		 ______   __       ________   _______    ______
		/_____/\ /_/\     /_______/\ /______/\  /_____/\
		\::::_\/_\:\ \    \::: _  \ \\::::__\/__\:::_ \ \
		 \:\/___/\\:\ \    \::(_)  \ \\:\ /____/\\:\ \ \ \
		  \:::._\/ \:\ \____\:: __  \ \\:\\_  _\/ \:\ \ \ \
		   \:\ \    \:\/___/\\:.\ \  \ \\:\_\ \ \  \:\/.:| |
		    \_\/     \_____\/ \__\/\__\/ \_____\/   \____/_/

2024-07-11T11:31:57.024+0200	info	cmd/start.go:107	flagd version: dev (da01e08), built at: 2024-07-11T11:14:44Z	{"component": "start"}
2024-07-11T11:31:57.026+0200	info	flag-sync/sync_service.go:54	starting flag sync service on port 8017	{"component": "FlagSyncService"}
2024-07-11T11:31:57.027+0200	info	grpc/grpc_sync.go:70	setting max receive message size 5728474 bytes default 4MB	{"component": "sync", "sync": "grpc"}

@pradeepbbl pradeepbbl requested a review from a team as a code owner July 11, 2024 09:43
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 11, 2024
@pradeepbbl pradeepbbl marked this pull request as draft July 11, 2024 09:43
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 6dfe9b1
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/669147a8d6112a0008040db7
😎 Deploy Preview https://deploy-preview-1358--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pradeepbbl pradeepbbl force-pushed the pmishra/1357-allow-max-message-size branch from 30cbc38 to eec5841 Compare July 11, 2024 15:24
@Kavindu-Dodan
Copy link
Contributor

@pradeepbbl DCO failed. Could you please sign your commits? You can follow simple steps here - https://github.com/open-feature/flagd/pull/1358/checks?check_run_id=27331145892

@Kavindu-Dodan Kavindu-Dodan requested review from thisthat and aepfli July 11, 2024 18:33
@pradeepbbl pradeepbbl force-pushed the pmishra/1357-allow-max-message-size branch from c87e2b1 to 304b35a Compare July 11, 2024 20:10
@pradeepbbl pradeepbbl marked this pull request as ready for review July 11, 2024 20:11
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 11, 2024
@pradeepbbl pradeepbbl force-pushed the pmishra/1357-allow-max-message-size branch from 304b35a to f482670 Compare July 11, 2024 20:13
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 11, 2024
@pradeepbbl pradeepbbl requested a review from Kavindu-Dodan July 11, 2024 20:14
@pradeepbbl pradeepbbl force-pushed the pmishra/1357-allow-max-message-size branch from f482670 to 987b3c8 Compare July 11, 2024 20:17
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 11, 2024
@pradeepbbl pradeepbbl force-pushed the pmishra/1357-allow-max-message-size branch from 5d67634 to 7267098 Compare July 11, 2024 20:18
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 11, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 11, 2024
@pradeepbbl pradeepbbl force-pushed the pmishra/1357-allow-max-message-size branch from e487e7c to 232d671 Compare July 11, 2024 21:09
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 11, 2024
pradeepbbl and others added 4 commits July 12, 2024 08:11
Added a new config option `maxMsgSize` which will
allow users to override default message size 4Mb.

Signed-off-by: Pradeep Mishra <pradeepbbl@gmail.com>
Signed-off-by: pradeepbbl <pradeepbbl@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Pradeep Mishra <pradeepbbl@users.noreply.github.com>
Signed-off-by: pradeepbbl <pradeepbbl@gmail.com>
Signed-off-by: Pradeep Mishra <pradeepbbl@gmail.com>
Signed-off-by: pradeepbbl <pradeepbbl@gmail.com>
Signed-off-by: Pradeep Mishra <pradeepbbl@gmail.com>
@Kavindu-Dodan Kavindu-Dodan force-pushed the pmishra/1357-allow-max-message-size branch from 3e27a34 to 6dfe9b1 Compare July 12, 2024 15:11
@Kavindu-Dodan Kavindu-Dodan added this to the flagd 0.11.2 milestone Jul 12, 2024
@Kavindu-Dodan Kavindu-Dodan merged commit bed077b into open-feature:main Jul 12, 2024
15 checks passed
@pradeepbbl pradeepbbl deleted the pmishra/1357-allow-max-message-size branch July 12, 2024 15:17
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
beeme1mr pushed a commit that referenced this pull request Aug 22, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.11.2</summary>

##
[0.11.2](flagd/v0.11.1...flagd/v0.11.2)
(2024-08-22)


### 🐛 Bug Fixes

* **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to
v1.5.1-20240215170432-1e611e2999cc.1
([#1372](#1372))
([ae24595](ae24595))
* **deps:** update module github.com/open-feature/flagd/core to v0.10.1
([#1355](#1355))
([8fcfb14](8fcfb14))
* **deps:** update module golang.org/x/net to v0.28.0
([#1380](#1380))
([239a432](239a432))
* **deps:** update module golang.org/x/sync to v0.8.0
([#1378](#1378))
([4804c17](4804c17))


### 🧹 Chore

* **deps:** update dependency go to v1.22.6
([#1297](#1297))
([50b92c1](50b92c1))
* **deps:** update golang docker tag to v1.23
([#1382](#1382))
([abb5ca3](abb5ca3))
* improve gRPC sync service shutdown behavior
([#1375](#1375))
([79d9085](79d9085))
</details>

<details><summary>flagd-proxy: 0.6.5</summary>

##
[0.6.5](flagd-proxy/v0.6.4...flagd-proxy/v0.6.5)
(2024-08-22)


### 🐛 Bug Fixes

* **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to
v1.5.1-20240215170432-1e611e2999cc.1
([#1372](#1372))
([ae24595](ae24595))
* **deps:** update module github.com/open-feature/flagd/core to v0.10.1
([#1355](#1355))
([8fcfb14](8fcfb14))
* **deps:** update module golang.org/x/net to v0.28.0
([#1380](#1380))
([239a432](239a432))
* **deps:** update module golang.org/x/sync to v0.8.0
([#1378](#1378))
([4804c17](4804c17))


### 🧹 Chore

* **deps:** update dependency go to v1.22.6
([#1297](#1297))
([50b92c1](50b92c1))
* **deps:** update golang docker tag to v1.23
([#1382](#1382))
([abb5ca3](abb5ca3))


### 📚 Documentation

* **flagd-proxy:** removed invalid grpc prefix from uri config
([4911697](4911697))
</details>

<details><summary>core: 0.10.2</summary>

##
[0.10.2](core/v0.10.1...core/v0.10.2)
(2024-08-22)


### 🐛 Bug Fixes

* **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to
v1.5.1-20240215170432-1e611e2999cc.1
([#1372](#1372))
([ae24595](ae24595))
* **deps:** update module connectrpc.com/otelconnect to v0.7.1
([#1367](#1367))
([184915b](184915b))
* **deps:** update module
github.com/open-feature/open-feature-operator/apis to v0.2.44
([#1368](#1368))
([0c68726](0c68726))
* **deps:** update module golang.org/x/crypto to v0.26.0
([#1379](#1379))
([05f6658](05f6658))
* **deps:** update module golang.org/x/mod to v0.20.0
([#1377](#1377))
([797d7a4](797d7a4))
* **deps:** update module golang.org/x/sync to v0.8.0
([#1378](#1378))
([4804c17](4804c17))


### ✨ New Features

* add 'watcher' interface to file sync
([#1365](#1365))
([61fff43](61fff43))
* added new grpc sync config option to allow setting max receive message
size. ([#1358](#1358))
([bed077b](bed077b))
* Support blob type sources and GCS as an example of such source.
([#1366](#1366))
([21f2c9a](21f2c9a))


### 🧹 Chore

* **deps:** update dependency go to v1.22.6
([#1297](#1297))
([50b92c1](50b92c1))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow user to set max message size limit on grpc source
4 participants