Skip to content

Commit

Permalink
fix: deprecation warning fix (#317)
Browse files Browse the repository at this point in the history
Signed-off-by: jamesmilligan <james@omnant.co.uk>

<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- fixes incorrect default on deprecation warning, preventing warning log
when the flag is not used

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

### Notes
<!-- any additional notes for this PR -->

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

### How to test
<!-- if applicable, add testing instructions under this section -->

Signed-off-by: jamesmilligan <james@omnant.co.uk>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
  • Loading branch information
james-milligan and beeme1mr authored Jan 25, 2023
1 parent 1bfb321 commit a2630db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ var startCmd = &cobra.Command{
"Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration.md")
}

if viper.GetString(evaluatorFlagName) != "" {
if viper.GetString(evaluatorFlagName) != "json" {
rtLogger.Warn("DEPRECATED: The --evaluator flag has been deprecated. " +
"Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration.md")
}
Expand Down

0 comments on commit a2630db

Please sign in to comment.