-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag set and flag metadata to schema #173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
toddbaert
reviewed
Dec 5, 2024
toddbaert
reviewed
Dec 5, 2024
toddbaert
requested review from
thisthat,
bacherfl,
Kavindu-Dodan,
aepfli and
craigpastro
December 5, 2024 19:00
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
aepfli
approved these changes
Dec 5, 2024
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
toddbaert
approved these changes
Dec 5, 2024
Merged
This was referenced Dec 11, 2024
Open
Open
beeme1mr
pushed a commit
that referenced
this pull request
Dec 20, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>protobuf: 0.6.2</summary> ## [0.6.2](protobuf-v0.6.1...protobuf-v0.6.2) (2024-12-05) ### ✨ New Features * add metadata to the AnyFlag response used for bulk eval ([#176](#176)) ([3acc9e4](3acc9e4)) </details> <details><summary>json/json-schema: 0.2.9</summary> ## [0.2.9](json/json-schema-v0.2.8...json/json-schema-v0.2.9) (2024-12-05) ### ✨ New Features * add flag set and flag metadata to schema ([#173](#173)) ([9fe3677](9fe3677)) ### 🧹 Chore * remove comment about summing to 100 ([#172](#172)) ([d03b772](d03b772)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
This lays the foundation for improved feature flag telemetry in flagd.
Follow up
Update the protos to expose the metadata.