Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag set and flag metadata to schema #173

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Nov 1, 2024

This PR

  • adds flag metadata
  • adds flag set metadata

Notes

This lays the foundation for improved feature flag telemetry in flagd.

Follow up

Update the protos to expose the metadata.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr linked an issue Nov 4, 2024 that may be closed by this pull request
@beeme1mr beeme1mr marked this pull request as ready for review November 6, 2024 17:50
@beeme1mr beeme1mr requested a review from a team as a code owner November 6, 2024 17:50
@beeme1mr beeme1mr requested a review from toddbaert November 6, 2024 17:54
json/flags.json Outdated Show resolved Hide resolved
json/flags.json Outdated Show resolved Hide resolved
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@toddbaert toddbaert merged commit 9fe3677 into main Dec 5, 2024
6 checks passed
@toddbaert toddbaert deleted the add-metadata-to-schema branch December 5, 2024 21:09
beeme1mr pushed a commit that referenced this pull request Dec 20, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>protobuf: 0.6.2</summary>

##
[0.6.2](protobuf-v0.6.1...protobuf-v0.6.2)
(2024-12-05)


### ✨ New Features

* add metadata to the AnyFlag response used for bulk eval
([#176](#176))
([3acc9e4](3acc9e4))
</details>

<details><summary>json/json-schema: 0.2.9</summary>

##
[0.2.9](json/json-schema-v0.2.8...json/json-schema-v0.2.9)
(2024-12-05)


### ✨ New Features

* add flag set and flag metadata to schema
([#173](#173))
([9fe3677](9fe3677))


### 🧹 Chore

* remove comment about summing to 100
([#172](#172))
([d03b772](d03b772))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the flagd schema to include flag metadata
3 participants