Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add README.md to the nuget package #164

Merged
merged 1 commit into from
Dec 14, 2023
Merged

docs: Add README.md to the nuget package #164

merged 1 commit into from
Dec 14, 2023

Conversation

askpt
Copy link
Member

@askpt askpt commented Dec 14, 2023

This PR

  • This PR is to close the issue related to the missing README.md file from the Nuget website.

Related Issues

Fixes #138

Notes

I followed the instructions from the website but I am not sure how to test if it's working correctly.

@askpt askpt requested a review from a team as a code owner December 14, 2023 13:56
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24c3441) 94.30% compared to head (6ee745e) 94.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files          21       21           
  Lines         650      650           
  Branches       54       54           
=======================================
  Hits          613      613           
  Misses         23       23           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askpt askpt changed the title Add README.md to the project docs: Add README.md to the nuget package Dec 14, 2023
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @askpt ... I don't think there's any way to test this other than to release it! 😄

If it doesn't work, I don't think we'll be any worse off. Thanks!

@askpt
Copy link
Member Author

askpt commented Dec 14, 2023

@toddbaert I'll keep an eye on it. If it fails reopen or ping me on slack 👍

@beeme1mr beeme1mr merged commit b6b0ee2 into open-feature:main Dec 14, 2023
10 of 11 checks passed
@askpt askpt deleted the askpt/138-add-readme branch December 14, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] add readme to published package
3 participants