Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Add targeting key to evaluation context #230

Closed
toddbaert opened this issue Feb 6, 2024 · 0 comments · Fixed by #231
Closed

[BUG] Add targeting key to evaluation context #230

toddbaert opened this issue Feb 6, 2024 · 0 comments · Fixed by #231
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

We need a targeting key in the evaluation context. It should be added to the builder, and should be immutable (like all the props in the current implementation).

The evaluation context also lacks the required 'targeting key` field

dotnet-sdk/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs

Line 46 in 2c237df

[Specification("3.1.1", "The `evaluation context` structure MUST define an optional `targeting key` field of type string, identifying the subject of the flag evaluation.")]

Originally posted by @roelofb in #204 (comment)
@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 6, 2024
@toddbaert toddbaert mentioned this issue Feb 6, 2024
Open
@toddbaert toddbaert added the bug Something isn't working label Feb 6, 2024
@toddbaert toddbaert changed the title Add targeting key to evaluation context [BUG] Add targeting key to evaluation context Feb 6, 2024
roelofb added a commit to roelofb/open-feature-dotnet-sdk that referenced this issue Feb 7, 2024
@roelofb
Fixes open-feature#230
55763c0
@roelofb roelofb mentioned this issue Feb 7, 2024
Merged
roelofb added a commit to roelofb/open-feature-dotnet-sdk that referenced this issue Feb 7, 2024
@roelofb
Fixes open-feature#230
28fea57 
Signed-off-by: Roelof Blom <roelof@rb2.nl>
toddbaert added a commit that referenced this issue Feb 12, 2024
@roelofb @austindrenski @toddbaert
fix: Add targeting key (#231)
d792b32 
Fixes #230

---------

Signed-off-by: Roelof Blom <roelof@rb2.nl>
Signed-off-by: Roelof Blom <roelof.blom@gmail.com>
Signed-off-by: Austin Drenski <austin@austindrenski.io>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Austin Drenski <austin@austindrenski.io>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
@ghelyar ghelyar mentioned this issue Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add targeting key roelofb/open-feature-dotnet-sdk
1 participant
@toddbaert