Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen JSON schema #66

Closed
beeme1mr opened this issue Dec 9, 2024 · 0 comments · Fixed by #68
Closed

Loosen JSON schema #66

beeme1mr opened this issue Dec 9, 2024 · 0 comments · Fixed by #68

Comments

@beeme1mr
Copy link
Member

beeme1mr commented Dec 9, 2024

Remove the "additionalProperties": false option so the flag manifest can be embedded in other configurations (e.g. flagd).
@beeme1mr beeme1mr mentioned this issue Jan 6, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 27, 2025
@beeme1mr
feat: add doc gen, move schema path, add tests, fix react gen (#68)
68a72ee 
## This PR

- moves JSON schema to a dedicated directory
- added schema validation tests
- fixed React code gen (and tests)
- automate CLI doc generation
- Loosen JSON schema
- ~~Rename default value~~

### Related Issues

Fixes #66

### Notes

It's a big PR that I could break into smaller changes if necessary.

---------

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <michael.beemer@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add doc gen, move schema path, add tests, fix react gen open-feature/cli
1 participant
@beeme1mr