Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic PR labelling action #109

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Add automatic PR labelling action #109

merged 1 commit into from
Mar 2, 2023

Conversation

teodutu
Copy link
Member

@teodutu teodutu commented Jan 23, 2023 •
edited
Loading

Uses labeler for assigning topic/* and area/* labels and a custom script for kind/* labels.
kind/new is assigned to any PR that contains a newly added file and kind/improvement is assigned to any PR that contains at least one file only with additions. The student-contrib and kind/fix labels are to be added manually.

Fixes #89.

Signed-off-by: Teodor Dutu teodor.dutu@gmail.com

@teodutu teodutu added this to the SO 2022-2023 sem 1 milestone Jan 23, 2023
@teodutu teodutu self-assigned this Jan 23, 2023
@teodutu teodutu marked this pull request as ready for review January 23, 2023 13:23
@teodutu teodutu added area/infra Update to infrastructure / scripts kind/new New content / item labels Jan 23, 2023
@teodutu teodutu force-pushed the add-labeler branch 5 times, most recently from 01056c2 to 4e75bc9 Compare January 23, 2023 19:40
gabrielmocanu
gabrielmocanu reviewed Jan 23, 2023
View reviewed changes
.github/workflows/labeler.yml Outdated
@@ -0,0 +1,24 @@
name: "Pull Request Labeler"
on: [pull_request]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned here this method won't work with pull_request. You should use something like this to schedule the workflow to run from time to time. Also I would add a workflow_dispatch just for testing purposes to check that this is working before merging it.

@teodutu teodutu removed area/infra Update to infrastructure / scripts kind/new New content / item labels Jan 23, 2023
@teodutu teodutu force-pushed the add-labeler branch 2 times, most recently from 6f68f14 to 35ada1e Compare January 23, 2023 20:12
@teodutu
Copy link
Member Author

teodutu commented Jan 23, 2023

I tested the scripts with a PR in my own fork, where the GITHUB_TOKEN works: teodutu#6.

gabrielmocanu
gabrielmocanu approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@gabrielmocanu gabrielmocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can integrate this.

@teodutu
infra: Add automatic PR labelling action
556679c 
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
@gabrielmocanu
Copy link
Contributor

We need this one faster

@teodutu teodutu merged commit 354857b into open-education-hub:master Mar 2, 2023
@teodutu teodutu deleted the add-labeler branch March 2, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmocanu gabrielmocanu gabrielmocanu approved these changes

@razvand razvand Awaiting requested review from razvand

@Sergiu121 Sergiu121 Awaiting requested review from Sergiu121

Assignees

@teodutu teodutu

Labels
None yet
Projects
None yet
Milestone
SO 2022-2023 sem 1
Development

Successfully merging this pull request may close these issues.

Automate assigning of GitHub labels to pull requests
2 participants
@teodutu @gabrielmocanu