Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEI-6680 key error on filtering username #326

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

mudassir-hafeez
Copy link
Contributor

@mudassir-hafeez mudassir-hafeez commented Apr 2, 2021

Jira ticket: https://mckinsey.atlassian.net/browse/MEI-6680

Fixed KeyError: 'student_id' as it raises when we search username through instructor tool.

@mudassir-hafeez
Copy link
Contributor Author

@xitij2000 can you please review?

@xitij2000
Copy link
Member

@mudassir-hafeez I'm afraid we might not be able to this for the next sprint. We will look into it after mid-april. I hope this is OK?

@mudassir-hafeez
Copy link
Contributor Author

Yup, @xitij2000 thanks for informing! Please take it after mid april.

@mudassir-hafeez
Copy link
Contributor Author

@xitij2000 just a reminder to review. Thanks!

Copy link
Member

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: tested on master devstack
  • I read through the code
  • [na] I checked for accessibility issues
  • [na] Includes documentation

@xitij2000 xitij2000 merged commit cb4125e into open-craft:master Apr 22, 2021
@xitij2000
Copy link
Member

@mudassir-hafeez I've tested, approved and merged this and also tagged a release.

@mudassir-hafeez mudassir-hafeez deleted the MCKIN-12600 branch April 22, 2021 11:12
@mudassir-hafeez
Copy link
Contributor Author

@xitij2000 thanks for reviewing!

@mudassir-hafeez mudassir-hafeez changed the title MCKIN-12600 key error on filtering username MEI-6680 key error on filtering username Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants