Apply SASS styles from agency #93
Conversation
| help_text=('The name of your institution, company or project.' | ||
| '\n\nExample: Hogwarts Online Learning'), | ||
| help_text=('The name of your institution, company or project.<br/>' | ||
| 'Example: Hogwarts Online Learning'), |
There was a problem hiding this comment.
Would it be possible to avoid using HTML in the help text?
There was a problem hiding this comment.
omarkhan
force-pushed
the
omar/sass
branch
4 times, most recently
from
6b21c6e to
1da90cc
Compare
| @@ -49,20 +64,22 @@ app.controller('Registration', ['$scope', '$http', 'djangoForm', function($scope | |||
| return _.keys($scope.form).filter(key => !/^\$/.test(key)); | |||
There was a problem hiding this comment.
@omarkhan The => function notation does not have very good browser support yet. It doesn't work with latest Safari on OS X, for example.
|
👍 |
|
|
||
| # Variables ################################################################### | ||
|
|
||
| SVN = svn checkout |
There was a problem hiding this comment.
Wouldn't svn export be the more appropriate command here? (I only vaguely remember svn commands, and I always got them wrong, so don't give too much on what I'm saying.)
There was a problem hiding this comment.
@smarnach Yeah, svn export would be better, but I think it only allows you to export the full repository (top-level folder) while here we want to only dowload the stylesheets subfolder.
There was a problem hiding this comment.
@mtyaka I just ran
svn export https://github.com/at-import/breakpoint/tags/v2.7.0/stylesheets
on my machine, and it worked fine. (If I remember correctly, there wasn't even a distinction in svn between a full repository and its subdirectories. Each subdirectory is a full repository in its own right.)
There was a problem hiding this comment.
Thanks for the tip @smarnach. I have never used subversion before, I didn't know about svn export. I have updated the Makefile to use svn export --force (without --force it refuses to download into the current directory)
|
Rebased, I will merge when the build is green. |
Testing
make rundev/registration/, check that everything works and looks right