[BB-9491] fix 404 pages on course details for other catalogs #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecoholic
force-pushed
the
tecoholic/BB-9491-limit-corurse-runs
branch
from
3795c6a to
9b8db24
Compare
tecoholic
force-pushed
the
tecoholic/BB-9491-limit-corurse-runs
branch
from
9b8db24 to
2ca650c
Compare
Agrendalath
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
👍
- I tested this: checked that the active course run is set
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- Added to the Code Drift project board (for backports)
Agrendalath
merged commit f238442
into
tecoholic/BB-8825-custom-ui
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #7 filtered the courses to the single course run allowed in the enteprise-catalog. However, the solution had the bug of not setting the correct
activeCourseRun. So, only the enterprise learners with the "advertisedCourseRun" could see the details.This PR fixes that bug by setting the
activeCourseRunof theCourseServiceand patching thegetActiveCourseRunutility function to return only the available course run, when only 1 is present.Before
After
Testing Instructions
Similar to the instructions from #7 for setup. Then switch to the second enterprise and load the course details page in Enterprise Learner Portal.