feat: add library v2 component in course #75
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## navin/improve-lib-buttons #75 +/- ##
============================================================
Coverage ? 93.01%
============================================================
Files ? 1048
Lines ? 20490
Branches ? 4418
============================================================
Hits ? 19059
Misses ? 1361
Partials ? 70 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @navinkarkera!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
| <StandardModal | ||
| title="Select component" | ||
| isOpen={isAddLibraryContentModalOpen} | ||
| onClose={closeAddLibraryContentModal} | ||
| isOverflowVisible={false} | ||
| size="xl" | ||
| > | ||
| <ComponentPicker | ||
| showOnlyPublished | ||
| onComponentSelected={handleLibraryV2Selection} | ||
| /> | ||
| </StandardModal> |
There was a problem hiding this comment.
We have the ComponentPickerModal, but I'm fine as you did here.
Maybe we shouldn't need the modal component after all.
There was a problem hiding this comment.
@rpenido Yes, we can use it but then have to modify it to have the same props as the ComponentPicker component in addition to StandardModal props.
Maybe we shouldn't need the modal component after all.
Agreed, it doesn't seem to be doing much except for wrapping component picker in a modal component.
Update: Removed: f32ae3e
Replace with standard modal and component picker components.
navinkarkera
force-pushed
the
navin/v2-library-content
branch
from
6c489d1 to
f32ae3e
Compare
* feat: add library v2 component in course * test: add test for lib v2 component * test: fix failing tests * refactor: remove ComponentPickerModal component Replace with standard modal and component picker components.
Description
Implements 2a. from openedx#1462
Supporting information
Private-ref: FAL-3936Testing instructions
Library contentoption is working.*You might have to manually increase the height of course unit iframe via developer console. Ref: openedx/edx-platform#35802