Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BB-9101] maintain default filter with pagination #69

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

pkulkark
Copy link
Member

This PR fixes the issue of pagination resetting the default filter in course authoring home page.

@pkulkark pkulkark force-pushed the pooja/bb9101-pagination-fix branch from c3155f5 to c4c4695 Compare September 16, 2024 17:19
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (acbd7fa) to head (c4c4695).
Report is 6 commits behind head on asu-moe/redwood-css.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #69      +/-   ##
=======================================================
+ Coverage                92.54%   92.60%   +0.06%     
=======================================================
  Files                      706      706              
  Lines                    12515    12524       +9     
  Branches                  2728     2735       +7     
=======================================================
+ Hits                     11582    11598      +16     
+ Misses                     898      891       -7     
  Partials                    35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cup0fCoffee
Copy link
Member

👍

  • I tested this: checked that when using pagination, only the active courses are displayed, unless filters are intentionally changed
  • I read through the code
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@pkulkark pkulkark merged commit a10524f into asu-moe/redwood-css Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants