Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assign taxonomy to organizations [TEMP] #23

Conversation

rpenido
Copy link
Member

@rpenido rpenido commented Dec 19, 2023

TEMP

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (rpenido/fal-3532-import-taxonomy@782fadd). Click here to learn what that means.

❗ Current head 5d2b314 differs from pull request most recent head 56e6c1e. Consider uploading reports for the commit 56e6c1e to get more accurate results

Additional details and impacted files
@@                         Coverage Diff                         @@
##             rpenido/fal-3532-import-taxonomy      #23   +/-   ##
===================================================================
  Coverage                                    ?   89.35%           
===================================================================
  Files                                       ?      479           
  Lines                                       ?     7606           
  Branches                                    ?     1626           
===================================================================
  Hits                                        ?     6796           
  Misses                                      ?      782           
  Partials                                    ?       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido I think you need to add some padding here. Like the modal on Figma

photo_2023-12-20_08-34-10

overflow: visible !important;

.pgn__modal-body {
overflow: visible;
Copy link
Member

@ChrisChV ChrisChV Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Could you add the reason of this style in a comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 9fbe76e!

Also updated the spacing here: aca5ce5

image

@ChrisChV
Copy link
Member

@rpenido Looks good, great work! 👍

  • I tested this: I tested all the workflow.
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes tests for bugfixes and/or features added.
  • Includes documentation

renovate bot and others added 7 commits December 21, 2023 11:37
…v1.177.9 (openedx#762)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This implements filtering taxonomies on the taxonomy list page by selecting organization name, all taxonomies, or unassigned taxonomies.
This change adds a new button in the Taxonomy List to allow users to create new taxonomies by importing a CSV/JSON file.
Add support for fetching content data for Library V2 components in content tags drawer.
@rpenido
Copy link
Member Author

rpenido commented Jan 8, 2024

Closed in favor of openedx#760

@rpenido rpenido closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants