Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent cross-org ObjectTags from being created #633

Merged
merged 3 commits into from
Feb 15, 2024
Merged

fix: prevent cross-org ObjectTags from being created #633

merged 3 commits into from
Feb 15, 2024

Commits on Feb 12, 2024

  1. fix: prevent cross-org ObjectTags from being created 

    A "cross-org" ObjectTag is when the object_id references an org that is
not in the taxonomy's allowed list of orgs.

Similarly, we forbid creating object tags for a taxonomy with no allowed
orgs listed.

This change adds a rules check for this case, and updates the tests.
    @pomegranited
    pomegranited committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    d81f0b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge branch 'jill/tagging-less-queries' into jill/tagging-cross-org

    @pomegranited
    pomegranited committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    66613ae View commit details
    Browse the repository at this point in the history

  2. fix: address PR review

    @pomegranited
    pomegranited committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    86d28fa View commit details
    Browse the repository at this point in the history