Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implements SHOW_REGISTRATION_LINKS feature toggle #528

Merged
merged 2 commits into from
Mar 30, 2023
Merged

feat: implements SHOW_REGISTRATION_LINKS feature toggle #528

merged 2 commits into from
Mar 30, 2023

Conversation

viadanna
Copy link
Member

@viadanna viadanna commented Mar 28, 2023 •
edited
Loading

Description

This PR implements a SHOW_REGISTRATION_LINKS configuration variable to allow hiding the links to the registration form.

Supporting information

BB-7271

Testing instructions

  1. Check https://lms.paulo.eshe.opencraft.hosting/ has no register button at the top
  2. Check https://lms.paulo.eshe.opencraft.hosting/register does work
  3. Check https://lms.paulo.eshe.opencraft.hosting/login doesn't show links to the registration form
  4. Check https://studio.lms.paulo.eshe.opencraft.hosting doesn't show links to register an account

Deadline

ASAP

@viadanna viadanna self-assigned this Mar 28, 2023
@viadanna viadanna marked this pull request as ready for review March 28, 2023 11:52
@navinkarkera
Copy link
Member

@viadanna If you click on Need help signing in link, then click on Forgot my password it takes you to Password assistance page where you can again click on Need help signing in link and there you can see the Create an account link.

image

@viadanna viadanna force-pushed the viadanna/hide-registration-form-BB-7271 branch from 182d6e1 to 80b330b Compare March 28, 2023 19:03
@viadanna viadanna changed the title feat: implements ALLOW_REGISTRATION_FORM feature toggle feat: implements SHOW_REGISTRATION_LINKS feature toggle Mar 29, 2023
@viadanna viadanna force-pushed the viadanna/hide-registration-form-BB-7271 branch from 48014c9 to eb56b8f Compare March 29, 2023 19:12
navinkarkera
navinkarkera reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viadanna

lms/templates/student_account/form_field.underscore Outdated Show resolved Hide resolved
navinkarkera
navinkarkera approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viadanna Nice. 👍

  • I tested this: (Tested it in the sandbox)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@viadanna viadanna merged commit 3025ab5 into opencraft-release/nutmeg.2 Mar 30, 2023
@viadanna viadanna deleted the viadanna/hide-registration-form-BB-7271 branch March 30, 2023 14:12
xitij2000 pushed a commit that referenced this pull request Jun 26, 2023
@viadanna @xitij2000
feat: implements SHOW_REGISTRATION_LINKS feature toggle (#528)
64d2883 
(cherry picked from commit 3025ab5)
@xitij2000 xitij2000 mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navinkarkera navinkarkera navinkarkera approved these changes

Assignees

@viadanna viadanna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viadanna @navinkarkera