Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Party role #3

Merged
merged 7 commits into from
Apr 16, 2020
Merged

Party role #3

merged 7 commits into from
Apr 16, 2020

Conversation

ColinMaudry
Copy link
Contributor

Adds the partyRole code list (open-contracting-extensions/european-union#65).

I took the definition of Central purchasing body from Article 2 1. 16) of directive 2014/24/EU.

I figured out the definition of "Process contact point" from the context.

The other definitions are either copied or derived from those mentioned in the issue`.

@ColinMaudry ColinMaudry requested a review from jpmckinney April 8, 2020 14:04
@ColinMaudry
Copy link
Contributor Author

Is it OK to have commits from the merged #2? Or shall I cancel this PR and do a new one?

@jpmckinney
Copy link
Member

I think you can do:

git checkout partyRole
git merge master
git push

Then, the old commits will disappear from the PR.

codelists/partyRole.csv Outdated Show resolved Hide resolved
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all descriptions, can you add articles, e.g.:

  • The body
  • A procuring entity
  • A contact point
  • The service
  • A party that

codelists/partyRole.csv Outdated Show resolved Hide resolved
codelists/partyRole.csv Outdated Show resolved Hide resolved
codelists/partyRole.csv Outdated Show resolved Hide resolved
@jpmckinney jpmckinney merged commit 212e69e into master Apr 16, 2020
@jpmckinney jpmckinney deleted the partyRole branch April 16, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants