fix(condo): DOMA-7969 fixed a imported date #4175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alllex202
force-pushed
the
fix/condo/DOMA-7969/fix-date-from-imported-ipu
branch
from
44bf8a4 to
e791174
Compare
toplenboren
approved these changes
Dec 14, 2023
nomerdvadcatpyat
approved these changes
Dec 15, 2023
Alllex202
force-pushed
the
fix/condo/DOMA-7969/fix-date-from-imported-ipu
branch
from
e791174 to
1517791
Compare
Alllex202
force-pushed
the
fix/condo/DOMA-7969/fix-date-from-imported-ipu
branch
from
1517791 to
1731c0c
Compare
|
Alllex202
added
🔬 WIP
|
The solution does not work as expected in all cases. Let's come back to this problem later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: V8 (JavaScript engine) has issue with Date.getTimeZoneOffset. Because of this, dates from files are not imported correctly and have some deviation from the specified date of a few seconds
Example:
Links:
https://bugs.chromium.org/p/v8/issues/detail?id=7863 - V8 (JavaScript engine) has issue with Date.getTimezoneOffset
SheetJS/sheetjs#1565 (comment) - Description and solution to the problem