-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace date-fns
by date-and-time-formatter
#443
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -151,7 +151,7 @@ const args = yargs(argsBeforeSep) | |
}, | ||
'timestamp-format': { | ||
alias: 't', | ||
describe: 'Specify the timestamp in moment/date-fns format.', | ||
describe: 'Specify the timestamp in Unicode LDML format.', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While this is technically correct, I wonder how many people won't know how to find usage examples for LDML. For instance, for me, Google returns one result for "unicode ldml" in the first page that is more "straight to the point" IMO: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point! Should we explicitly link https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns in this description? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably, but i'm worried it might not be formatted well by yargs. Something like #445 (or better) is looking promising now... |
||
default: defaults.timestampFormat, | ||
type: 'string', | ||
}, | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -61,7 +61,7 @@ export const success = 'all' as SuccessCondition; | |||||
|
||||||
/** | ||||||
* Date format used when logging date/time. | ||||||
* @see https://date-fns.org/v2.0.1/docs/format | ||||||
* @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
*/ | ||||||
export const timestampFormat = 'yyyy-MM-dd HH:mm:ss.SSS'; | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -43,7 +43,7 @@ export type ConcurrentlyOptions = BaseConcurrentlyOptions & { | |||||
|
||||||
/** | ||||||
* Date format used when logging date/time. | ||||||
* @see https://date-fns.org/v2.0.1/docs/format | ||||||
* @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
*/ | ||||||
timestampFormat?: string; | ||||||
|
||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.