Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build_ffmpeg option #175

Merged
merged 5 commits into from
May 31, 2023
Merged

Conversation

cdeepali
Copy link
Contributor

Checklist before submitting

Description

Fixes # (issue).

Review process to land

  1. All tests and other checks must succeed.
  2. At least one maintainer must review and approve.
  3. If any maintainer requests changes, they must be addressed.

README.md Outdated

One can build Open-CE packages with ffmpeg by providing `--build-ffmpeg` option to `open-ce build env` command. When this option is provided, Open-CE Builder builds [`envs/ffmpeg-env.yaml`](https://github.com/open-ce/open-ce/blob/main/envs/ffmpeg-env.yaml) internally and then builds the provided Open-CE environment file for which the build is requested.

`--build_ffmpeg` is not supported with `--fips`. `ffmpeg` package is built by default via `openssl-env.yaml` when `--fips` is set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One can build Open-CE packages with ffmpeg in two ways:

  • Provide --build-ffmpeg option to the open-ce build env command. When this option is provided, Open-CE Builder builds envs/ffmpeg-env.yaml internally and then builds the provided Open-CE environment file for which the build is requested.
  • Provide --fips option to the open-ce build env command. This will use the openssl-env.yaml, which includes ffmpeg by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@cdeepali cdeepali merged commit 86a6d5a into open-ce:main May 31, 2023
@cdeepali cdeepali deleted the dc-buildffmpeg-main branch May 31, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants