Updated readme for issue# 324 and some miscellaneous changes #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlang74
reviewed
Oct 13, 2022
doc/README.open_ce_build.md
Outdated
| ```shell | ||
| echo "startup --output_user_root=/dev/shm/.cache" >> ~/.bazelrc | ||
| ``` | ||
|
|
||
| Other environment files for other packages can also be found in the `envs` |
There was a problem hiding this comment.
I think this sentence should go before the bazel section
npanpaliya
changed the title
alexlang74
reviewed
Oct 13, 2022
doc/README.open_ce_build.md
Outdated
| @@ -455,14 +463,14 @@ For example: | |||
| GCC 11 setup is automated if the builds are done in a podman container using `--container_build` option. Please see [`Dockerfile`](https://github.com/open-ce/open-ce-builder/blob/main/open_ce/images/builder/Dockerfile-p10) used for containerized build of these packages. | |||
|
|
|||
| #### Build packages | |||
| Power10 MMA Optimization is applicable for cpu only builds. One has to use `--ppc_arch=p10` flag in the `open-ce build env` or `open-ce build feedstock` command to build P10 enabled packages. Another important argument which is must to build these packages is `--conda_build_config=open-ce/envs/conda_build_config.yaml,open-ce/envs/conda_build_config_p10.yaml`.[`conda_build_config_p10.yaml`](https://github.com/open-ce/open-ce/blob/main/envs/conda_build_config_p10.yaml) contains Power10 specific settings. | |||
| Power10 MMA Optimization is applicable for cpu only builds. One has to use `--ppc_arch=p10` flag in the `open-ce build env` or `open-ce build feedstock` command to build P10 enabled packages. Another important argument which is must to build these packages is `--conda_build_config=open-ce/envs/conda_build_config.yaml,open-ce/envs/conda_build_config_p10.yaml`.[`conda_build_config_p10.yaml`](https://github.com/open-ce/open-ce/blob/main/envs/conda_build_config_p10.yaml) contains Power10 specific settings. | |||
There was a problem hiding this comment.
Suggestion:
Power10 MMA Optimization is applicable for cpu only builds. To build Power10 packages, use one of the following options:
- To build an individual environment:
open-ce build env --ppc_arch=p10 --conda_build_config=open-ce/envs/conda_build_config.yaml,open-ce/envs/conda_build_config_p10.yaml <environment yaml>. Example:open-ce build env --build_type=cpu --ppc_arch=p10 --conda_build_config=open-ce/envs/conda_build_config.yaml,open-ce/envs/conda_build_config_p10.yaml tensorflow-env.yaml - To build an individual feedstock:
open-ce build feedstock --ppc_arch=p10 --conda_build_config=open-ce/envs/conda_build_config.yaml,open-ce/envs/conda_build_config_p10.yaml <feedstock> - To build all Power10 enabled packages in one go:
open-ce build env --ppc_arch=p10 opence-p10-env.yaml:
Codecov ReportBase: 96.17% // Head: 96.17% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 23 23
Lines 2116 2116
=======================================
Hits 2035 2035
Misses 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alexlang74
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before submitting
Description
Addressed open-ce/open-ce#324.
Review process to land