removing much code duplication (#41)

* removing much code duplication * removing more lines of code * complying with vscode * correcting windows action
open-atmos · Jan 24, 2024 · 88c40a2 · 88c40a2
1 parent 04476b2
commit 88c40a2
Show file tree

Hide file tree

Showing 4 changed files with 1,206 additions and 1,604 deletions.
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -18,11 +18,7 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - name: Run CMake
-      run: cmake -S . -B build -A ${{ matrix.architecture }}
-      if: matrix.build_type == 'Release'
-    - name: Run CMake
-      run: cmake -S . -B build -A ${{ matrix.architecture }}
-      if: matrix.build_type == 'Debug'
+      run: cmake -S . -B build -A ${{ matrix.architecture }} -D CMAKE_BUILD_TYPE=${{ matrix.build_type }}
     - name: Build
       run: cmake --build build --config ${{ matrix.build_type }} --parallel 10
     - name: Run tests

diff --git a/include/open_atmos/types.hpp b/include/open_atmos/types.hpp
@@ -33,7 +33,7 @@ namespace open_atmos
     struct ReactionComponent
     {
       std::string species_name;
-      double coefficient;
+      double coefficient { 1.0 };
       /// @brief Unknown properties, prefixed with two underscores (__)
       std::unordered_map<std::string, std::string> unknown_properties;
     };