Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples #481

Merged
merged 6 commits into from
Jul 25, 2022
Merged

Improve examples #481

merged 6 commits into from
Jul 25, 2022

Conversation

zorbash
Copy link
Contributor

@zorbash zorbash commented Jul 24, 2022

The goals of this PR are the following:

  • Modernise the plug example code (bump dependencies and fix warnings)
  • Add tests so that we can quickly ensure changes to the library are not breaking a realistic app
  • Demonstrate how assert_schema/2 and OpenApiSpex.Schema.example/1 can be used in the tests of an app using open_api_spex

zorbash added 2 commits July 24, 2022 20:32
The error:

** (Plug.Conn.WrapperError) ** (Plug.Conn.InvalidHeaderError) header key is not lowercase: "Content-Type"
@zorbash zorbash requested a review from mbuhot July 24, 2022 21:21
@zorbash zorbash force-pushed the improve-examples branch from a9fb77f to e41c0ab Compare July 24, 2022 21:22
Copy link
Collaborator

@mbuhot mbuhot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

Does the empty file priv/repo/plug_app_dev.db need to be committed?

@zorbash
Copy link
Contributor Author

zorbash commented Jul 25, 2022

@mbuhot Removed the db file and I have updated the .gitignore to ignore it.

@zorbash zorbash merged commit db84e88 into master Jul 25, 2022
@zorbash zorbash deleted the improve-examples branch July 25, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants