fix: support RequestBody passed to operation macro #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operation macro currently supports passing arguments for url params,
request body and response schemas in a "simplified" way (as
tuples/keyword lists).
It also supports passing operation structs like `%Parameter{}` and
`%Response{}`.
However it didn't support passing `%RequestBody{}`, for example this:
```elixir
operation :update
summary: "Update user",,
request_body: %RequestBody{
#...
}
# ...
```
would result in `%Operation{requestBody: nil}`.
This changeset fixes it so that we get the expected behaviour of
`%Operation{requestBody: %RequestBody{}}`.
Geekfish
force-pushed
the
fix/operation-explicit-structs
branch
from
ce6d7c2 to
b7cfe69
Compare
mbuhot
approved these changes
May 27, 2022
|
Thanks for the lightning-fast review @mbuhot 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation macro currently supports passing arguments for url params, request body and response schemas in a "simplified" way (as tuples/keyword lists).
It also supports passing operation structs like
%Parameter{}and%Response{}.However, it didn't support passing
%RequestBody{}, for example this:would result in
%Operation{requestBody: nil}.This changeset fixes it so that we get the expected behaviour of
%Operation{requestBody: %RequestBody{}}.Fixes: #457