Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/response object default #301

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

brentjr
Copy link
Contributor

@brentjr brentjr commented Nov 6, 2020

#300

Fixes error when attempting to use the key :default for a response in the responses map.

test/controller_test.exs Outdated Show resolved Hide resolved
@mbuhot
Copy link
Collaborator

mbuhot commented Nov 9, 2020

Looks pretty good @brentjr 👍
I haven't tested the inline suggestions above, but I think we should be able to use the atom :default throughout instead of the string "default"?

Copy link
Collaborator

@mbuhot mbuhot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brentjr !

@mbuhot mbuhot merged commit 367e1bd into open-api-spex:master Nov 9, 2020
@moxley moxley mentioned this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants