Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misspelled word in example Phoenix app README.md #396

Closed
pxp9 opened this issue Nov 21, 2021 · 2 comments
Closed

Misspelled word in example Phoenix app README.md #396

pxp9 opened this issue Nov 21, 2021 · 2 comments

Comments

@pxp9
Copy link
Contributor

pxp9 commented Nov 21, 2021 •
edited
Loading

First at all really useful library for building APIs while building a web app.

In description of file schemas.ex it is misspelled the word "contains".

I know that is not important as other things but is easy to fix. Good luck.

EDIT: 22-11-2021 also is misspelled in the other example.

ksnip_20211121-234848
@mbuhot
Copy link
Collaborator

mbuhot commented Nov 21, 2021

Hi @pxp9 thanks for reporting the issue, spelling is important!

Care to submit a PR? It makes it easier for me to credit you in the release notes :)

@pxp9 pxp9 mentioned this issue Nov 22, 2021
Merged
mbuhot pushed a commit that referenced this issue Nov 22, 2021
@pxp9
Improve documentation #396 (#397)
4280a88 
* Update README.md files
@mbuhot
Copy link
Collaborator

mbuhot commented Nov 22, 2021

Resolved in #397 , thanks again @pxp9 👍

@mbuhot mbuhot closed this as completed Nov 22, 2021
lucacorti pushed a commit to lucacorti/open_api_spex that referenced this issue Feb 13, 2022
@pxp9 @lucacorti
Improve documentation open-api-spex#396 (open-api-spex#397)
3fa8a6d 
* Update README.md files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbuhot @pxp9