fix: issue #729 and use Buffer rather than string for CIRAChannel's s… #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #732 +/- ##
==========================================
+ Coverage 93.38% 93.65% +0.26%
==========================================
Files 78 78
Lines 3295 3293 -2
Branches 532 527 -5
==========================================
+ Hits 3077 3084 +7
+ Misses 218 209 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
orinem
force-pushed
the
issue_729
branch
2 times, most recently
from
4c1d642
to
458c356
Compare
Closed
|
This does make the construction of the SendChannelData packet inconsistent with the other packets. However, the change has the advantage that the test's calculation of the expected data is no longer a duplication of the same code as it's still using string functions. |
…ng for CIRAChannel's sendBuffer Added test for CIRAChannel writeData() binary path
matt-primrose
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Fix issue #729 by ensuring UTF8 encoding isn't lost before going on the wire.
Renders issue #662 moot as Content-Length is used instead of chunked encoding.
Anything the reviewer should know when reviewing this PR?
Work in progress! The is experimental code. It does not appear to have broken anything, though occasionally adding alarm instances fails for unknown reasons with the device reporting invalid xml. A silly level log message has been added to try to catch this case.
Other SendXXX functions in APFProcessor could possibly benefit from building the buffer in place as was required in SendChannelData.
Added "SendPendingData" to replace essentially identical code that appeared in three places.
The fix for decoding UTF8 from the device is very inefficient.