Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mps): tls cipher selection #634

Merged
merged 11 commits into from
Jul 21, 2022
Merged

fix(mps): tls cipher selection #634

merged 11 commits into from
Jul 21, 2022

Conversation

vinayg-intel
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #634 (5983e13) into main (086b241) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   92.96%   92.97%   +0.01%     
==========================================
  Files          71       71              
  Lines        3069     3074       +5     
  Branches      526      501      -25     
==========================================
+ Hits         2853     2858       +5     
- Misses        209      216       +7     
+ Partials        7        0       -7     
Impacted Files Coverage Δ
src/utils/certificates.ts 100.00% <100.00%> (ø)
src/index.ts 50.00% <0.00%> (ø)
src/server/mpsserver.ts 92.53% <0.00%> (ø)
src/utils/wsRedirect.ts 81.03% <0.00%> (ø)
src/routes/amt/auditLog.ts 69.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086b241...5983e13. Read the comment docs.

@graikhel-intel graikhel-intel merged commit 54b0c5e into main Jul 21, 2022
@graikhel-intel graikhel-intel deleted the mpsSecure branch July 21, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants