Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LERC_jll 3 to 4, downgrade DimensionalData to 0.27.9, Julia Pkg update #879

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

arlowhite
Copy link
Collaborator

@arlowhite arlowhite commented Oct 13, 2024

The GDAL error related to LERC@4 in Linux is fixed:
JuliaGeo/GDAL.jl#179
JuliaPackaging/Yggdrasil#9588

Ran update in both Julia 1.11 and 1.10
Some minor updates to other packages, see manifest diff.

Downgraded DimensionalData and GeoMakie (compat) to fix Unit Tests.

Changed Unit Tests workflow to run on PRs that modify manifest to catch these issues in the future.


DimensionalData Error

#881

This PR's Unit Tests and the previous main run failed.

ERROR: LoadError: DimensionMismatch: Lookup values for DimensionalData.Dimensions.Dim{:species} of [1, 8, 15, 22, 29] and [2, 9, 16, 23, 30] do not match.

https://github.com/open-AIMS/ADRIA.jl/actions/runs/11247637592/job/31271460535#step:6:1130

Worried that DimensionalData update from 0.27 to 0.28 in PR #878 is a problem. Verifying...

GeoMakie 0.7 Error

#882

@arlowhite arlowhite changed the title LERC_jll 4, Julia Pkg update LERC_jll 3 to 4, downgrade DimensionalData to 0.27.9, Julia Pkg update Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.36%. Comparing base (390a466) to head (fb9db9d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #879   +/-   ##
=======================================
  Coverage   49.36%   49.36%           
=======================================
  Files          70       70           
  Lines        4734     4734           
=======================================
  Hits         2337     2337           
  Misses       2397     2397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arlowhite arlowhite marked this pull request as ready for review October 14, 2024 06:00
Copy link
Collaborator

@ConnectedSystems ConnectedSystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all pass locally in a fresh REPL session.

@ConnectedSystems ConnectedSystems merged commit 2f09ada into main Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants