-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the tgi service images for gaudi #451
Conversation
can we confirm all the models used in GenAIExamples are supported by latest-xeon-cpus? |
Yeah, sure, let me confirm with @lvliang-intel |
based on the test output, tgi pod crashed during test, so I guess it's still not working yet. |
Seeing this error message at TGI pod, so it looks like the latest tgi image doesn't work with this model correctly. BTW, if we want to upgrade to tgi-gaudi:2.0.5, the "gaudi-values.yaml" in TGI helm chart should also be updated. |
f1e88f2
to
3aae23c
Compare
Hi @yongfengdu and @lianhao, after discussed with Intel Xeon TGI image support engineer, we'd better to use the specified version of TGI image, such as |
1884cd7
to
ca52fc2
Compare
CI fail is for the CPU values file. That fails also in #454 which does not change any of the components used in CI (it skips HPA testing), unlike this one. Therefore it's possible that the failure is not related to the TGI update (unless that increases TGI resource usage, or slows it down). |
Please wait for PR #456 to land-in first, then rebase to trigger the test to see if it still exists |
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
for more information, see https://pre-commit.ci
@zhlsunshine for the test failure of GMC E2e Test on Xeon which is unrelated to this PR itself, GenAIComps PR 608 could be the trigger for that failure. But could you double check if there is any issue in the GMC router which would cause trouble when trying to forward back large amount of streaming data from tgi to the end user? |
Hi @lianhao, I noticed that there are some parameters change in request, however, GMC router just pass through them, so I do not think there is issue for these changes. |
Description
Update the tgi service images for both xeon and gaudi.
Issues
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a
.Tests
n/a
.