Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using PV as model cache directory #290

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

yongfengdu
Copy link
Collaborator

Set modelUsePV to pvc name for model cache

Description

modelUsePV support

Issues

#128

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Verified using nfs as PV backend.
Setup example:
PV:
apiVersion: v1
kind: PersistentVolume
metadata:
name: nfspv
spec:
capacity:
storage: 300Gi
volumeMode: Filesystem
accessModes:
- ReadWriteMany
persistentVolumeReclaimPolicy: Retain
storageClassName: nfs
nfs:
path: "/data/nfspv"
server: "192.168.0.184"
readOnly: false

PV Claim:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: model-volume
spec:
accessModes:
- ReadWriteMany
storageClassName: "nfs"
resources:
requests:
storage: 1Mi

Test example with whisper:
helm install whisper whisper --set global.modelUseHostPath="" --set global.modelUsePV=model-volume --set replicaCount=4 --set image.tag=latest

Set modelUsePV to pvc name for model cache

Signed-off-by: Dolpher Du <Dolpher.Du@intel.com>
@lianhao
Copy link
Collaborator

lianhao commented Aug 12, 2024

We need to add a common README of how to use and configure PV to be used. But that could be done in another PR, since we need to figure out where to put it

Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daisy-ycguo daisy-ycguo merged commit c0d2ba6 into opea-project:main Aug 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants