Update DocIndexRetriever Example to allow user passing in retriever/reranker params #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: minmin-intel <minmin.hou@intel.com>
minmin-intel
requested review from
xuechendi and
lvliang-intel
and removed request for
lvliang-intel
for more information, see https://pre-commit.ci
Signed-off-by: minmin-intel <minmin.hou@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: minmin-intel <minmin.hou@intel.com>
…/GenAIExamples into retrieval-tool-v1.1
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: minmin-intel <minmin.hou@intel.com>
for more information, see https://pre-commit.ci
lvliang-intel
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously there is no interface for user to set retriever/reranker params. This PR will allow user passing in retriever/reranker params in requests to the retrieval tool gateway.
Issues
n/a.Type of change
Dependencies
No newly introduced 3rd party dependency if exists.
Tests
Unit tests in test folder.