Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml: add comments to specify gaudi device ids. #753

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

feng-intel
Copy link
Collaborator

Description

Add comments to specify gaudi device ids.

Issues

#739

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • [* ] Others (enhancement, documentation, validation, etc.)

Dependencies

no

Tests

ChatQnA/docker/gaudi/README.md Outdated Show resolved Hide resolved
@chensuyue
Copy link
Collaborator

chensuyue commented Sep 10, 2024

Should also update in test scripts,

export DATAPREP_DELETE_FILE_ENDPOINT="http://${ip_address}:6009/v1/dataprep/delete_file"

Copy link
Collaborator

@pallavijaini0525 pallavijaini0525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: fengding <feng1.ding@intel.com>
@chensuyue chensuyue merged commit 63406dc into opea-project:main Sep 11, 2024
10 checks passed
dmsuehir pushed a commit to dmsuehir/GenAIExamples that referenced this pull request Sep 11, 2024
Signed-off-by: fengding <feng1.ding@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants