-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yaml: add comments to specify gaudi device ids. #753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feng-intel
force-pushed
the
yaml_device_id
branch
2 times, most recently
from
September 6, 2024 07:25
cc7a31a
to
44effc4
Compare
feng-intel
force-pushed
the
yaml_device_id
branch
from
September 6, 2024 07:33
81dc03b
to
41f5246
Compare
letonghan
approved these changes
Sep 6, 2024
lvliang-intel
approved these changes
Sep 6, 2024
feng-intel
force-pushed
the
yaml_device_id
branch
from
September 9, 2024 06:59
3fd9d20
to
b86df80
Compare
feng-intel
force-pushed
the
yaml_device_id
branch
from
September 10, 2024 02:51
b86df80
to
066b982
Compare
feng-intel
force-pushed
the
yaml_device_id
branch
2 times, most recently
from
September 10, 2024 07:19
0a9db21
to
d125eda
Compare
Should also update in test scripts,
|
feng-intel
force-pushed
the
yaml_device_id
branch
from
September 10, 2024 09:53
4be18f3
to
3f68322
Compare
pallavijaini0525
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feng-intel
force-pushed
the
yaml_device_id
branch
from
September 11, 2024 00:48
dd30b74
to
fc8c19e
Compare
Signed-off-by: fengding <feng1.ding@intel.com>
feng-intel
force-pushed
the
yaml_device_id
branch
from
September 11, 2024 01:30
95a5515
to
9f31ec2
Compare
dmsuehir
pushed a commit
to dmsuehir/GenAIExamples
that referenced
this pull request
Sep 11, 2024
Signed-off-by: fengding <feng1.ding@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add comments to specify gaudi device ids.
Issues
#739
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
no
Tests