Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinecone update to Readme and docker compose for ChatQnA #540

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Pinecone update to Readme and docker compose for ChatQnA #540

wants to merge 51 commits into from

Conversation

pallavijaini0525
Copy link
Collaborator

Description

Added the Readme and Docker compose files for Pinecone DB for ChatQnA usecase

Issues

#411

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Others (enhancement, documentation, validation, etc.)

@pallavijaini0525 pallavijaini0525 mentioned this pull request Aug 7, 2024
Open
@chensuyue
Copy link
Collaborator

  1. Do we need a separate readme?
  2. ChatQnA/docker/xeon/docker_compose_pinecone.yaml --> ChatQnA/docker/xeon/compose_pinecone.yaml
  3. Please add an example e2e test, like this one, https://github.com/opea-project/GenAIExamples/blob/main/ChatQnA/tests/test_chatqna_on_xeon.sh

@pallavijaini0525
Copy link
Collaborator Author

@chensuyue -> Sure i will add the tests, can you please help in adding the PINECONE_KEY to the project variables simialr to HF_TOKEN, so i can use that key for the tests.

@ZePan110 has added for GenAIComps

@chensuyue chensuyue mentioned this pull request Aug 13, 2024
Merged
4 tasks
@chensuyue
Copy link
Collaborator

@chensuyue -> Sure i will add the tests, can you please help in adding the PINECONE_KEY to the project variables simialr to HF_TOKEN, so i can use that key for the tests.

@ZePan110 has added for GenAIComps

#579

@pallavijaini0525
Copy link
Collaborator Author

Tests are added and file is renamed to compose_pinecone.yaml

@arun-gupta
Copy link
Contributor

What is the current status of this merge?

In addition, can opea/*-pinecone Docker images be pushed to Docker Hub? This will simplify the overall developer experience.

@pallavijaini0525
Copy link
Collaborator Author

Only the docker compose and Readme files are not merged which are part of this PR, In GenAIComps, pinecone related changes are merged

@arun-gupta
Copy link
Contributor

Seems like @chensuyue requested some changes. Can we make them so that it can be integrated?

@pallavijaini0525 pallavijaini0525 force-pushed the pinecone_update branch 3 times, most recently from 331e481 to 2088b19 Compare September 11, 2024 15:43
@pallavijaini0525
Copy link
Collaborator Author

@chensuyue -> All issues are resolved, please review

@chensuyue
Copy link
Collaborator

@chensuyue -> All issues are resolved, please review

Because the test scripts name not adapt to the new structure, the test is actually not triggered.

@pallavijaini0525 pallavijaini0525 force-pushed the pinecone_update branch 7 times, most recently from e13bce5 to a5ade94 Compare September 18, 2024 15:50
pallavijaini0525 and others added 24 commits October 16, 2024 04:48
@pallavijaini0525
Added the pinecone support documentation and docker compose file
9c30df4 
Signed-off-by: pallavi jaini <pallavi.jaini@intel.com>
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pallavijaini0525
Updated the readme for pinecone
22e918f 
Signed-off-by: pallavi jaini <pallavi.jaini@intel.com>
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
20adebe 
for more information, see https://pre-commit.ci

Signed-off-by: pallavi jaini <pallavi.jaini@intel.com>
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pallavijaini0525
Added port 6009 to pinecone
6bae689 
Signed-off-by: pallavi jaini <pallavi.jaini@intel.com>
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pallavijaini0525
Added the tests and renamed the files
aa21352 
Signed-off-by: Pallavi Jaini <pallavi.jaini@intel.com>
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Updated the pinecone tests as per the xeon
d0b1ba3 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Updated the Dockerfile pathf or rerank
1345ea8 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Updated the file name for the tests
4133cfa 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Corrected the docker compose for pinecone
1a3247c 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Corrected the docker compose for pinecone
49b8708 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
75135b0 
for more information, see https://pre-commit.ci

Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Corrected the test script issue
d5da891 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
468957d 
for more information, see https://pre-commit.ci

Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Fixed the issues with tests
17fd96b 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Fixed the links
f32236f 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Corrected the tag
429be00 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Corrected the ports
1ab8626 
Signed-off-by: AI Workloads <aigoldrush1@g2-r3-2.iind.intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pallavijaini0525
Commented out dataprep as not able to connect to pineconeserver
05a6b65 
Signed-off-by: Pallavi Jaini <pallavi.jaini@intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
70b7159 
for more information, see https://pre-commit.ci

Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pallavijaini0525
Added more comments
7628f33 
Signed-off-by: Pallavi Jaini <pallavi.jaini@intel.com>
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Validated in IDC and enabled all the tests in pinecone
98d8eb4 
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
19f95bf 
for more information, see https://pre-commit.ci

Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
Merge remote-tracking branch 'origin/pinecone_update' into pinecone_u…
1a59f91 
…pdate
Implemented all review comments
6aa1720 
Signed-off-by: Pallavi Jaini <pallavi,jaini@intel.com>
@chensuyue chensuyue mentioned this pull request Oct 16, 2024
Merged
4 tasks
root and others added 5 commits October 16, 2024 07:09
Updated the pinecone key
822d109 
Signed-off-by: root <root@test-pjaini.535545281608.us-region-2.idcservice.net>
@chensuyue
Merge branch 'main' into pinecone_update
a83b36f
@chensuyue
Merge branch 'main' into pinecone_update
9b14a97
@pallavijaini0525
Made changes to reflect the new framework
15362dc 
Signed-off-by: Pallavi Jaini <pallavi.jaini@intel.com>
@pallavijaini0525
Fixed the typos
0b559c6 
Signed-off-by: Pallavi Jaini <pallavi.jaini@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensuyue chensuyue chensuyue left review comments

@lvliang-intel lvliang-intel Awaiting requested review from lvliang-intel lvliang-intel is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pallavijaini0525 @chensuyue @arun-gupta