Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct ip to no_proxy list, and add no_proxy env for embedding and reranking containers #269

Closed
wants to merge 3 commits into from

Conversation

ctao456
Copy link
Contributor

@ctao456 ctao456 commented Jun 7, 2024

Description

Add no_proxy env for embedding-tei-server container

Append host_ip to the no_proxy list

Issues

We need to pass no_proxy setting to embedding and reranking microservices. As in the PR below
(#267)

Also, we need to append host_ip, the public host ipv4 address, to the no_proxy list stored in the no_proxy variable.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.
(opea-project/GenAIComps#140)
(#267)

Tests

With this patch,

Embedding Microservice ok
curl http://${host_ip}:6000/v1/embeddings
-X POST
-d '{"text":"hello"}'
-H 'Content-Type: application/json'

Reranking Microservice ok
curl http://${host_ip}:8000/v1/reranking
-X POST
-d '{"initial_query":"What is Deep Learning?", "retrieved_docs": [{"text":"Deep Learning is not..."}, {"text":"Deep learning is..."}]}'
-H 'Content-Type: application/json'

@ctao456 ctao456 marked this pull request as draft June 8, 2024 23:31
@ctao456 ctao456 marked this pull request as ready for review June 8, 2024 23:37
@ctao456 ctao456 closed this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant