Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SetConsoleTextAttribute() #139

Merged
merged 8 commits into from
Oct 29, 2017
Merged

Implement SetConsoleTextAttribute() #139

merged 8 commits into from
Oct 29, 2017

Conversation

opalmer
Copy link
Owner

@opalmer opalmer commented Oct 29, 2017

Fixes #129.

@opalmer opalmer added this to the 0.5.0 milestone Oct 29, 2017
@opalmer opalmer self-assigned this Oct 29, 2017
@opalmer
Copy link
Owner Author

opalmer commented Oct 29, 2017

@rodrigc PTAL.

@codecov-io
Copy link

codecov-io commented Oct 29, 2017 •
edited
Loading

Codecov Report

Merging #139 into master will increase coverage by 0.03%.
The diff coverage is 100%.

rodrigc
rodrigc approved these changes Oct 29, 2017
View reviewed changes
Copy link
Contributor

@rodrigc rodrigc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but please add a test where dwDesiredAccess is None before you merge.

@opalmer opalmer merged commit 7c59543 into master Oct 29, 2017
@opalmer opalmer deleted the SetConsoleTextAttribute branch October 29, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigc rodrigc rodrigc approved these changes

Assignees

@opalmer opalmer

Labels
enhancement lib: kernel32 required-for: twisted
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@opalmer @codecov-io @rodrigc