Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions fix #138

Merged
merged 2 commits into from
Oct 29, 2017
Merged

Exceptions fix #138

merged 2 commits into from
Oct 29, 2017

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Oct 29, 2017

Add the error message to the WindowsAPIError text.

This facilitates debugging CreateProcess() failures.

@codecov-io
Copy link

codecov-io commented Oct 29, 2017 •
edited
Loading

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@rodrigc
Use format strings
cef7db4
@rodrigc
Add the error message to the WindowsAPIError text.
4d59e91 
This facilitates debugging CreateProcess() failures.
@opalmer opalmer added this to the 0.5.0 milestone Oct 29, 2017
@opalmer
Copy link
Owner

opalmer commented Oct 29, 2017

Looks good merging, thanks!

@opalmer opalmer merged commit 4a4256b into opalmer:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rodrigc rodrigc

Labels
enhancement
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigc @codecov-io @opalmer