Fix inconsistencies in test execution when flushing type caches #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
#73 has introduced
ObjectType.flushTypeCache(),ArrayType.flushTypeCache()and corresponding test cases. As mentioned here, these tests seem to (randomly) induce test failures.Changes in this PR
As mentioned in my reply to the original comment, this PR changes the algorithm for flushing the caches. Now the
cacheis completely cleared, and re-filled afterwards.I want to point out that i ran the
TypeTest, the entire BR test suite and all OPAL unit tests multiple times, and did not encounter any error. However, i was also unable to reproduce the initial error on my machine, so i can't guarantee that this fixes the issue.