Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(protocol): Replace use of OpBlock with alloy type generic over transaction #47

Merged
merged 28 commits into from
Jan 14, 2025
Merged

chore(protocol): Replace use of OpBlock with alloy type generic over transaction #47

merged 28 commits into from
Jan 14, 2025

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 11, 2025 •
edited
Loading

Based on #46

Replaces use of type alias OpBlock with Block<T>. maili-protocol only uses deposit transaction in block and header. Wherever deposit transaction is used, relies on OpTransaction trait.

@emhane emhane force-pushed the emhane/replace-op-block branch from 1ab4cbd to 0d948d2 Compare January 11, 2025 14:04
@emhane emhane force-pushed the emhane/replace-op-block branch from 0d948d2 to 1bd57d5 Compare January 11, 2025 14:11
@emhane emhane added the C-blocked Category: cannot move forward until something else changes label Jan 11, 2025
@emhane
Copy link
Member Author

emhane commented Jan 11, 2025

blocked by release of #46

mattsse
mattsse reviewed Jan 11, 2025
View reviewed changes
crates/common/src/deposit/mod.rs Outdated Show resolved Hide resolved
crates/common/src/deposit/mod.rs Outdated Show resolved Hide resolved
@emhane emhane force-pushed the emhane/replace-op-block branch from 6262e99 to e4e7e9a Compare January 12, 2025 15:46
@emhane
Copy link
Member Author

emhane commented Jan 13, 2025

blocked by alloy-rs/alloy#1913

Base automatically changed from emhane/op-tx to main January 13, 2025 15:10
@emhane emhane removed the C-blocked Category: cannot move forward until something else changes label Jan 13, 2025
@emhane
Copy link
Member Author

emhane commented Jan 13, 2025

incorporating changes from alloy-rs/alloy#1913 in later issue

refcell
refcell approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is very nice! Very much like the relaxed constraints

@emhane emhane mentioned this pull request Jan 14, 2025
Merged
mattsse
mattsse approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo making this generic is a good idea, this way all of this can be used by opstack nodes with custom txs

@emhane emhane merged commit bb688c1 into main Jan 14, 2025
12 of 20 checks passed
@emhane emhane deleted the emhane/replace-op-block branch January 14, 2025 16:25
sergerad pushed a commit to sergerad/maili that referenced this pull request Jan 23, 2025
@emhane @sergerad
chore(protocol): Replace use of OpBlock with alloy type generic ove…
0f499e4 
…r transaction (op-rs#47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@mattsse mattsse mattsse approved these changes

@clabby clabby Awaiting requested review from clabby clabby is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emhane @mattsse @refcell