Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executor): EIP-2935 Syscall Support [ISTHMUS] #963

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jan 28, 2025

Description

The Isthmus hardfork introduces the EIP-2935 contract to serve historical block hashes from state.

This PR adds support to kona's executor to syscall the contract.

Makes progress on #950

@refcell refcell requested review from clabby and emhane as code owners January 28, 2025 17:58
@refcell refcell self-assigned this Jan 28, 2025
@refcell refcell added K-feature Kind: feature A-protocol Area: protocol crates H-isthmus Hardfork: Isthmus related labels Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 42.22222% with 78 lines in your changes missing coverage. Please review.

Project coverage is 88.8%. Comparing base (debed6a) to head (27edfc1).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/syscalls/eip2935.rs 37.0% 78 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell changed the title feat(executor): EIP-2935 Syscall Support feat(executor): EIP-2935 Syscall Support [ISTHMUS] Jan 28, 2025
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can de-dup the TxEnv filling logic between these new system calls though.

@refcell refcell merged commit d9d1752 into main Jan 28, 2025
15 of 16 checks passed
@refcell refcell deleted the rf/eip2935-syscall branch January 28, 2025 18:52
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
This was referenced Feb 5, 2025
byteflyfunny pushed a commit to mantle-xyz/kona that referenced this pull request Feb 13, 2025
byteflyfunny pushed a commit to mantle-xyz/kona that referenced this pull request Feb 14, 2025
byteflyfunny added a commit to mantle-xyz/kona that referenced this pull request Mar 4, 2025
* adjust kona code to support Mantle's current version

- Updated kona-executor codebase to ensure compatibility with the latest Mantle version

* feat: Add EigenDA as a new data source for retrieval

* feature: Adjust derive code to adapt to the Mantle version.

* feature: Adjust derive code to adapt to the Mantle version.

* feat: adapt revm for mantle

* feature: Adjust derive code to adapt to the Mantle version.

* remove grpc request method for zkvm compile

* add test;

* update revm

* add some errors type

* pub use some types

* Refactor code structure; update alloy package version; add new features.

* change bin for proof

* remove da_indexer

* remove da_indexer

* chore: Improve error handling messages for Eigen DA

* add log info

* add log info

* add log info

* add log info

* add log info

* add log info

* fix bug in eigen da blob size

* debug derive

* debug derive

* debug derive

* debug derive

* fix: set base_fee to None (#2)

* build: remove useless deps

* fix: Prior to Holocene activation, this base_fee should always be none

* fix: use non problematic hashmap fns

* Synchronize the latest remote repository code on the main branch; rebase the development branch onto the main branch.

* feat(build): Adjust RV target - `riscv64g` -> `riscv64ima` (op-rs#868)

* feat(build): `riscv64g` -> `riscv64ima`

* turn off `ziscr`, `zfencei`, `zicntr`, `zihpm`

* fmt

* fix

* fix(derive): `BatchStream` Past batch handling (op-rs#876)

* fix(derive): `BatchStream` Past batch handling

* test

* feat(build): Bump `asterisc-builder` version (op-rs#879)

* fix: op-rs rename (op-rs#883)

* fix: op-rs rename

* fix: justfile

* chore: op-rs rename:

* chore(derive): Test Ignoring EIP-7702 (op-rs#887)

* fix: Small Spelling Issue (op-rs#893)

* Move temporary error logs to lower level than WARN (op-rs#897)

* chore: fix some typos in comment (op-rs#906)

Signed-off-by: piguagua <piguagua@aliyun.com>

* feat(driver): Multi-block derivation (op-rs#888)

Co-authored-by: refcell <abigger87@gmail.com>

* chore(executor): Remove `anyhow` dev-dependency (op-rs#937)

* feat: use empty requests hash when isthmus enabled (op-rs#951)

* feat: Derive Eq/Ord/Hash for (Archived) PreimageKey(Type) (op-rs#956)

* feat: allow 7702 receipts after Isthmus active (op-rs#959)

* feat: fill eip 7702 tx env with auth list (op-rs#958)

Co-authored-by: refcell <abigger87@gmail.com>

* feat(executor): EIP-2935 Syscall Support [ISTHMUS] (op-rs#963)

* feat(executor): EIP-7251 Syscall Support [ISTHMUS] (op-rs#968)

* chore(executor): TxEnv Stuffing (op-rs#970)

* feat(client): EIP-2537 BLS12-381 Curve Precompile Acceleration (op-rs#960)

Co-authored-by: clabby <ben@clab.by>

* chore(executor): De-duplicate `TrieAccount` type (op-rs#977)

* fix(executor): Removes EIP-7002 and EIP-7251 Pre-block Calls (op-rs#990)

* feat(proof-sdk): Cleanup `Hint` API (op-rs#998)

* feat(mpt): Copy-on-hash (op-rs#1001)

* feat(host): Accelerate all BLS12-381 Precompiles (op-rs#1010)

* chore(client): Dedup MSM Required Gas Fn (op-rs#1012)

* chore(client): Precompile Run Macro (op-rs#1014)

* feat(executor): Sort trie keys (op-rs#1016)

* feat(ci): Remove support for features after MSRV (op-rs#1018)

* update upstream kona with some cherry pick commit

* implemente clear func in eigenda source

* fix: deposit_receipt_version should be None (#6)

* fix: deposit_receipt_version should be None

* chore: cargo fmt

* Mantle kona mpt verify (#7)


* downgrade the version of crossbeam-channel

* Integrated the adjusted Hokulea and rust-kzg-bn254.

* Integrated the eigenda verify

* Adjust the EigenDA blob saving method to temporarily use one-time saving.

* Optimize EigenDA blob data caching and proof generation.

* optimize log levels

* feat: support 7702 && cargo fmt

* fix decode blob data bug

* change eigen da point file

* update op-alloy

* without verification for commitment

* remove point file

---------

Co-authored-by: PinelliaC <wylbzc4928@gmail.com>

---------

Signed-off-by: piguagua <piguagua@aliyun.com>
Co-authored-by: PinelliaC <wylbzc4928@gmail.com>
Co-authored-by: clabby <ben@clab.by>
Co-authored-by: refcell <abigger87@gmail.com>
Co-authored-by: Serge Radinovich <47865535+sergerad@users.noreply.github.com>
Co-authored-by: piguagua <piguagua@aliyun.com>
Co-authored-by: Rami <2418646+hashcashier@users.noreply.github.com>
Co-authored-by: Julian Meyer <julianmeyer2000@gmail.com>
Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>
Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-protocol Area: protocol crates H-isthmus Hardfork: Isthmus related K-feature Kind: feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants