[player-1545] Adding in variable to enable skippable ads for iOS10+ #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pilievOoyala will be fixing and adding unit tests |
…ck if param sets correct setting in IMA sdk.
…oad and loadMetadata called, so we have the page level overrides and avoid a possible race condition. Adjusting the unit tests to work too.
aeng7
reviewed
Sep 12, 2017
| @@ -12,6 +12,7 @@ google = | |||
| google.ima.linearAds = true; | |||
| google.ima.delayAdRequest = false; | |||
| google.ima.adsRenderingSettingsInstance = null; | |||
| google.ima.disableCustomPlaybackForIOS10Plus = false; | |||
There was a problem hiding this comment.
Can you defined this up above as well? This way it does not start out as undefined.
aeng7
reviewed
Sep 12, 2017
js/google_ima.js
Outdated
| @@ -630,7 +637,10 @@ require("../html5-common/js/utils/utils.js"); | |||
| { | |||
| //resumeAd will only be called if we have exited fullscreen | |||
| //so this is safe to call | |||
| this.sharedVideoElement.webkitEnterFullscreen(); | |||
| if (OO.isIosMajorVersion < 10) | |||
There was a problem hiding this comment.
Can we use a separate function to calculate if we support inline playback on iOS? That way we can use this new function here and down below when we exit full screen.
aeng7
reviewed
Sep 12, 2017
js/google_ima.js
Outdated
| //in the case where skippable ads are enabled we want to exit fullscreen | ||
| //because custom playback is disabled and ads can't be rendered in fullscreen. | ||
| if (OO.iosMajorVersion >= 10 && this.enableIosSkippableAds === true) { | ||
| this.sharedVideoElement.webkitExitFullscreen(); |
There was a problem hiding this comment.
See above comment for webkitEnterFullscreen about using a separate function.
|
LGTM |
aeng7
approved these changes
Sep 12, 2017
|
Single review merging to get it in this build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to verify that iPad is still okay and that all events for exitingFullscreen get propogated to the rest of the player. There also seems to be a race condition for trying to exit fullscreen but we are going to live with it for the moment as it's only for midroll, so we are going to advice customers only use prerolls if they want skippable ads.