테스트 환경 설정 및 리팩터링 #261
Merged
테스트 환경 설정 및 리팩터링 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lechros
requested review from
jinhoon227 and
kkmin223
and removed request for
jinhoon227
kkmin223
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
question : 이거 어떻게 사용하나요?
There was a problem hiding this comment.
저는 IntelliJ 도커 탭으로 실행하고, 제 컴퓨터 환경(윈도우) 기준 스프링은 로컬에 비해 컨테이너가 많이 느려서 로컬로 실행하고 있어요.
커맨드 쓰신다면 아마 아래와 같이 하면 될거예요.
docker compose -f compose.dev.yml up
c659754 to
3b9b84e
Compare
Lechros
force-pushed
the
refactor/docker
branch
from
3b9b84e to
e525e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 내용
개발 환경
Dockerfile에dev및prod모드 설정 (기본:prod)dev모드compose.dev.yml파일 추가테스트 환경
IntegrationTestSupport상속받도록 수정@Transactional어노테이션을 메서드에서 테스트 클래스로 이동DBCleaner.execute는 테스트 클래스 단위로 설정되므로 일관성 있도록DBCleanUp->DBCleaner로 이름 변경 및 하드코딩 리팩터링 (Spring 및 Hibernate 내에서 Cleanup보다 Cleaner 명칭을 더 선호함)application-test.yaml파일에서 불필요한 속성 제거기타
application-dev.yaml파일은 변경되지 않아 기존 방식대로 실행 가능@Transactional어노테이션이 없는 테스트 클래스에 구현해야 함 (OotdServiceMultiThreadTest등)createdAt으로 정렬하는 테스트의 경우 일정 확률로 실패함@DataJpaTest를 사용하도록 변경할 지?@SpringBootTest를 사용해도 테스트 시간 10초로 충분히 빠름