Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 테스트 환경 설정 #258

Merged
merged 2 commits into from
Nov 17, 2024
Merged

test: 테스트 환경 설정 #258

merged 2 commits into from
Nov 17, 2024

Conversation

kkmin223
Copy link
Collaborator

  • Test 프로필 분리
  • Transactional 어노테이션 제거

- Test 프로필 분리
- Transactional 어노테이션 제거
Copy link
Collaborator

@Lechros Lechros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

application-test.yamltest/resources 경로로 옮기고 기존 설정과 동일한 내용은 변경하는게 좋을 것 같아요.

timeout: 10
profiles:
include: secret
data:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: 레디스 사용에 spring.jpa.data.redisspring.data.redis 둘 다 필요한가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spring.data.redis만 필요한 것으로 확인해서 제거했습니다.

- test yaml 위치 수정
- redis 중복 설정 제거
@kkmin223 kkmin223 requested a review from Lechros November 16, 2024 10:13
@Lechros
Copy link
Collaborator

Lechros commented Nov 17, 2024

테스트에서만 사용되는 파일이므로 테스트 리소스로 옮기는 건 어떻게 생각하시나요?

@kkmin223
Copy link
Collaborator Author

테스트에서만 사용되는 파일이므로 테스트 리소스로 옮기는 건 어떻게 생각하시나요?

test 하단에 resource로 옮겼습니다~

Copy link
Collaborator

@Lechros Lechros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (폰이라 커밋이 제대로 안보였었나봐요.)

@kkmin223 kkmin223 merged commit 3ad49f1 into develop Nov 17, 2024
1 check passed
@kkmin223 kkmin223 deleted the test/config branch November 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants