Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

probe-engine: cannot run measurements using psiphon proxy #2810

Closed
DecFox opened this issue Oct 22, 2024 · 1 comment · Fixed by ooni/probe-android#852
Closed

probe-engine: cannot run measurements using psiphon proxy #2810

DecFox opened this issue Oct 22, 2024 · 1 comment · Fixed by ooni/probe-android#852
Assignees
@DecFox
Labels
bug Something isn't working funder/otffoss2023-2024 priority/high triage

Comments

@DecFox
Copy link
Collaborator

DecFox commented Oct 22, 2024

Describe the bug

It seems running the probe with the psiphon proxy errors out with:

Error - clientlib: StartTunnel called multiple times.

We should look into this as currently, we cannot run measurement using the proxy.
@DecFox DecFox added bug Something isn't working priority/high triage labels Oct 22, 2024
@DecFox DecFox self-assigned this Oct 22, 2024
@DecFox
Copy link
Collaborator Author

DecFox commented Oct 22, 2024 •
edited
Loading

On further investigation: it seems some changes were made to the upstream psiphon dependency we use, to the StartTunnel function: https://github.com/Psiphon-Labs/psiphon-tunnel-core/blob/staging-client/ClientLibrary/clientlib/clientlib.go#L140 which we integrated in the last release. The error seems to arise in the check here.

@DecFox DecFox mentioned this issue Oct 25, 2024
Merged
4 tasks
@DecFox DecFox mentioned this issue Nov 21, 2024
Merged
DecFox added a commit to ooni/probe-cli that referenced this issue Nov 21, 2024
@DecFox
refactor(oonimkall): expose the session close call (#1657)
051ab4a 
## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#2810
- [ ] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: <!-- add URL here -->
- [ ] if you changed code inside an experiment, make sure you bump its
version number

<!-- Reminder: Location of the issue tracker:
https://github.com/ooni/probe -->

## Description

This diff exposes the `Session.Close` call for the geoip session we
initialize in the mobile app. This is required to close the
circumvention tunnel before we use start another tunnel as part of the
async tasks to run the experiments.
aanorbel pushed a commit to ooni/probe-android that referenced this issue Nov 29, 2024
@DecFox
fix(engine): expose session close (#852)
8a98099 
Fixes ooni/probe#2810

## Proposed Changes

  - Exposes the `close` function for the engine session 
- Invokes the `close` function while downloading urls for
webconnectivity to ensure the running psiphon tunnel (and engine
session) is closed before the experiment run
- Changes in engine api surface:
ooni/probe-cli#1657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DecFox DecFox

Labels
bug Something isn't working funder/otffoss2023-2024 priority/high triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(engine): expose session close ooni/probe-android
2 participants
@jbonisteel @DecFox