Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: stop using model.ArchivalMaybeBinaryData #2543

Open
bassosimone opened this issue Sep 28, 2023 · 0 comments
Open

engine: stop using model.ArchivalMaybeBinaryData #2543

bassosimone opened this issue Sep 28, 2023 · 0 comments
Assignees
@bassosimone
Labels
cleanup There's need to cleanup stuff a bit ooni/probe-engine priority/low techdebt This issue describes technical debt

Comments

@bassosimone
Copy link
Contributor

As part of #2531 and, more specifically, of a quest to rationalize how we represent HTTP requests and responses and apply more aggressive scrubbing, I removed ArchivalMaybeBinaryData from most of the tree and replaced it with either ArchivalBinaryData or ArchivalMaybeBinaryString. A few usages of ArchivalMaybeBinaryData remain on tree. We should evaluate case by case whether to switch to ArchivalBinaryData or `ArchivalMaybeBinaryString.
@bassosimone bassosimone added priority/low ooni/probe-engine techdebt This issue describes technical debt cleanup There's need to cleanup stuff a bit labels Sep 28, 2023
@bassosimone bassosimone self-assigned this Sep 28, 2023
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 28, 2023
@bassosimone
cleanup: move ArchivalMaybeBinaryData to legacymodel
292df1c 
This diff concludes most of the development work associated with
ooni/probe#2531. We move the nearly unused
ArchivalMaybeBinaryData to the internal/legacy/legacymodel package
to clearly mark it deprecated.

Finishing removing this struct is a task that is documented by
ooni/probe#2543.
@bassosimone bassosimone mentioned this issue Sep 28, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 28, 2023
@bassosimone
cleanup: move ArchivalMaybeBinaryData to legacymodel (#1336)
a37f9c1 
This diff concludes most of the development work associated with
ooni/probe#2531. We move the nearly unused
ArchivalMaybeBinaryData to the internal/legacy/legacymodel package to
clearly mark it deprecated.

Finishing removing this struct is a task that is documented by
ooni/probe#2543.
@bassosimone bassosimone mentioned this issue Oct 2, 2023
Closed
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
cleanup: move ArchivalMaybeBinaryData to legacymodel (ooni#1336)
21b8ef6 
This diff concludes most of the development work associated with
ooni/probe#2531. We move the nearly unused
ArchivalMaybeBinaryData to the internal/legacy/legacymodel package to
clearly mark it deprecated.

Finishing removing this struct is a task that is documented by
ooni/probe#2543.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
cleanup There's need to cleanup stuff a bit ooni/probe-engine priority/low techdebt This issue describes technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone