Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add os_version to annotations #415

Merged
merged 1 commit into from
Jan 27, 2025
Merged

feat: add os_version to annotations #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composeApp/src/commonMain/kotlin/org/ooni/engine/Engine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ class Engine(
networkType = networkTypeFinder(),
flavor = buildSoftwareName(taskOrigin),
origin = taskOrigin,
ooniRunLinkId = descriptorId?.value?.toString() ?: "",
osVersion = platformInfo.osVersion,
ooniRunLinkId = descriptorId?.value ?: "",
),
proxy = preferences.proxy,
)
Expand Down
2 changes: 2 additions & 0 deletions composeApp/src/commonMain/kotlin/org/ooni/engine/models/TaskSettings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,7 @@ data class TaskSettings(
@SerialName("origin") val origin: TaskOrigin,
// only for ooni-run
@SerialName("ooni_run_link_id") var ooniRunLinkId: String? = null,
// system version (Android API version and iOS OS Version)
@SerialName("os_version") val osVersion: String,
)
}
2 changes: 1 addition & 1 deletion composeApp/src/iosMain/kotlin/org/ooni/probe/SetupDependencies.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class SetupDependencies(
override val buildNumber =
(NSBundle.mainBundle.infoDictionary?.get("CFBundleVersion") as? String).orEmpty()
override val platform = Platform.Ios
override val osVersion = with(UIDevice.currentDevice) { "$systemName $systemVersion" }
override val osVersion = with(UIDevice.currentDevice) { systemVersion }
override val model = UIDevice.currentDevice.model
override val needsToRequestNotificationsPermission = true
override val sentryDsn = "https://a19b2c03b50acdad7d5635559a8e2cad@o155150.ingest.sentry.io/4508325650235392"
Expand Down
Loading