Engine bridge interface + Android implementation #30
Conversation
|
Will look into that. |
| options = | ||
| TaskSettings.Options( | ||
| noCollector = true, | ||
| softwareName = Config.BASE_SOFTWARE_NAME, |
There was a problem hiding this comment.
This software_name is set to ooniprobe-android-unattended when the tests are run from the background and ooniprobe-android.
See Raw Measurement Data in https://explorer.ooni.org/m/20240731235959.972250_IE_webconnectivity_50b43329c29ed566
There was a problem hiding this comment.
For now, you can disregard the DashboardViewModel.kt code. I just kept the "Run Test" working to see if everything was fine. But we're never collecting/uploading, we still need to do the Engine SDK to properly set all configs.
| @@ -73,7 +77,19 @@ class DashboardViewModel( | |||
| TaskSettings( | |||
| name = "web_connectivity", | |||
There was a problem hiding this comment.
We may want to start defining various test "classes" as some tests have different keys.
There was a problem hiding this comment.
Same reply #30 (comment)
composeApp/src/commonMain/kotlin/org/ooni/engine/models/TaskSettings.kt
Outdated
Show resolved
Hide resolved
| Wifi("wifi"), | ||
| Mobile("mobile"), |
There was a problem hiding this comment.
We may want to start thinking of devices connected to the internet through TRANSPORT_BLUETOOTH, TRANSPORT_ETHERNET, TRANSPORT_USB especially on android that supports these options in the Mobile Hotspot and Tethering option.
There was a problem hiding this comment.
Interesting. Didn't think about those, I was just following the current implementation on the Android app. Maybe that will be future work, after we reach feature parity?
|
|
||
| object TaskLogLevelSerializer : KSerializer<TaskLogLevel> { | ||
| override val descriptor = | ||
| PrimitiveSerialDescriptor("TaskLogLevel", PrimitiveKind.STRING) |
There was a problem hiding this comment.
Do we want to use class name here?
There was a problem hiding this comment.
The official examples use the class name of the type we're serializing: https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/serializers.md#primitive-serializer
Closes #17
Closes #19
The
OonimkallBridge.ktfile is the most important part, the Bridge interface each platform has to implement. I believe I covered all our use cases, but please check.I tried hiding the Session Context inside the bridge implementations. I feel it isn't too much on an hassle for the platforms. Not sure what timeout to use though.
@aanorbel Hope you can help with the iOS implementation :) (#20)